Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid dynamic block usage for email notifications #6

Merged

Conversation

salemgolemugoo
Copy link
Contributor

@salemgolemugoo salemgolemugoo commented May 26, 2022

what

  • Fixes email notifications
  • subscriber_email_addresses is always empty even if you provide some emails to this parameter

why

  • Bug in the module

references

  • Example input which causes this issue
 budgets = [
    {
      name = "TotalBudgetMonthly"
      budget_type = "COST"
      limit_amount = 1000
      limit_unit = "USD"
      time_unit = "MONTHLY"

      notification = [
        {
          comparison_operator = "GREATER_THAN"
          threshold = 30
          threshold_type = "PERCENTAGE"
          notification_type = "ACTUAL"
          subscriber_email_addresses = ["[email protected]"]
        },
        {
          comparison_operator = "GREATER_THAN"
          threshold = 60
          threshold_type = "PERCENTAGE"
          notification_type = "ACTUAL"
          subscriber_email_addresses = ["[email protected]"]
        },
        {
          comparison_operator = "GREATER_THAN"
          threshold = 90
          threshold_type = "PERCENTAGE"
          notification_type = "ACTUAL"
          subscriber_email_addresses = ["[email protected]"]
        }
      ]
    }
  ]

@salemgolemugoo salemgolemugoo changed the title Fixed an invalid dynamic block usage for email notifications Fixed invalid dynamic block usage for email notifications May 26, 2022
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 16, 2022
@nitrocode nitrocode merged commit 214ff3d into cloudposse:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants