Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added auto_adjust_data attribute #29

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

mayank0202
Copy link
Contributor

@mayank0202 mayank0202 commented Jan 21, 2024

what

  • No breaking changes were done , added only one attribute in budgets resource type i.e auto_adjust_data and its optional but its a new attribute that has been seen in terraform docs.

why

  • I've determined that enabling the auto_adjust_data attribute is essential for aligning with business requirements and best practices for cost management. My testing has confirmed that its inclusion doesn't cause any functional disruptions, and it offers the added benefit of triggering email notifications upon auto-adjustments, enhancing visibility into budget changes. Therefore, I strongly recommend incorporating this attribute in our Terraform configuration to ensure optimal budget management and adherence to business needs.
    screenshot is attached below:

IMG_5597

references

@mayank0202
Copy link
Contributor Author

I tried to follow the instructions and i ran make init and make clean
make init was successful but make clean was failing
here is the screenshot of the error

readme error

@joe-niland
Copy link
Member

@mayank0202 you can try:

make init
make github/init
make readme

@joe-niland joe-niland self-requested a review January 21, 2024 22:15
@mayank0202
Copy link
Contributor Author

@mayank0202 you can try:

make init
make github/init
make readme

I tried these commands and i am getting still same error

@joe-niland
Copy link
Member

I think there's an issue with gomplate being installed by make. Can you try installing it manually?

@mayank0202
Copy link
Contributor Author

mayank0202 commented Jan 21, 2024

I think there's an issue with gomplate being installed by make. Can you try installing it manually?

Yes i installed manually and ran those makefile commands and it worked 👍

@mayank0202
Copy link
Contributor Author

mayank0202 commented Jan 21, 2024

I ran and it was a success and i pushed to the PR but still the check is not getting passed . i saw some merged PRs and in that PRs also these two checks are failing

@joe-niland
Copy link
Member

Yes, I think there is a bug in terraform-docs in setting the aws provider constraint. I will ask the team about that.

For now, if you don't mind, please fix that manually in line with the check output and it should be OK.

@mayank0202
Copy link
Contributor Author

mayank0202 commented Jan 21, 2024

Yes, I think there is a bug in terraform-docs in setting the aws provider constraint. I will ask the team about that.

For now, if you don't mind, please fix that manually in line with the check output and it should be OK.

This manual line in file was created by make readme only. i removed it .

@joe-niland
Copy link
Member

/terratest

@joe-niland joe-niland added the patch A minor, backward compatible change label Jan 22, 2024
@joe-niland joe-niland merged commit 9e62307 into cloudposse:main Jan 22, 2024
18 checks passed
@joe-niland
Copy link
Member

Thanks for your contribution @mayank0202 !

@mayank0202 mayank0202 deleted the feature/adjust-data branch January 22, 2024 03:08
@mayank0202
Copy link
Contributor Author

Thanks for your contribution @mayank0202 !

Thanks @joe-niland 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of auto_adjust_data attribute in budget resource
2 participants