Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cost_types #10

Merged
merged 3 commits into from
Dec 17, 2022
Merged

add cost_types #10

merged 3 commits into from
Dec 17, 2022

Conversation

algolucky
Copy link
Contributor

what

  • adds support for cost_types

why

  • otherwise, you cannot exclude things like support costs from threshold calculation

references

@algolucky algolucky requested review from a team as code owners October 3, 2022 19:44
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode enabled auto-merge (squash) December 17, 2022 16:18
@nitrocode nitrocode merged commit 9d17ca7 into cloudposse:master Dec 17, 2022
@algolucky algolucky deleted the add-cost-types branch December 19, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algolucky @nitrocode @cloudpossebot