Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger rules for passing tests #3520

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Stronger rules for passing tests #3520

merged 3 commits into from
Apr 20, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 6, 2023

what

  • Strengthen the rules required for automatic approving and merging via Mergify
  • Give jobs unique names so that Mergify can tell them apart

why

  • Previous rules failed to stop Update saml2aws to 2.36.6 #3484 from being merged despite the failure to build the package because a second package built without error. The new rules are intended to prevent a repeat of that situation.

references

@Nuru Nuru requested a review from a team as a code owner April 6, 2023 00:59
@github-actions github-actions bot added the github label Apr 6, 2023
@Nuru Nuru marked this pull request as draft April 6, 2023 03:30
@Nuru Nuru marked this pull request as ready for review April 19, 2023 15:41
@Nuru Nuru requested review from osterman and aknysh April 19, 2023 15:45
@Nuru Nuru enabled auto-merge (squash) April 19, 2023 15:49
@Nuru Nuru disabled auto-merge April 20, 2023 04:48
@Nuru Nuru merged commit 4cfc8d1 into master Apr 20, 2023
@Nuru Nuru deleted the mergify branch April 20, 2023 04:49
@Nuru Nuru mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant