Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace context with default var #52

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: replace context with default var #52

merged 1 commit into from
Sep 25, 2024

Conversation

mtweeman
Copy link
Contributor

@mtweeman mtweeman commented Sep 19, 2024 •
edited
Loading

what

  • Replace context with default variable

why

  • When using container within GitHub Actions, context value is incorrect. Default variable value remains correct.
  • As github.action_path is used during step execution (within runner), it can be replaced by default variable.

references

There are more reported issues showing this problem in various scenarios, for instance this one

@goruha goruha changed the base branch from main to fix/action-path September 23, 2024 16:00
@goruha goruha merged commit acdb5a8 into cloudposse:fix/action-path Sep 25, 2024
6 of 11 checks passed
This was referenced Sep 25, 2024
Merged
Merged
Merged
goruha added a commit that referenced this pull request Sep 25, 2024
@goruha @mtweeman
fix: replace context with default var (#52) (#53)
79cdb81 
Co-authored-by: mtweeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtweeman @goruha