-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bindfs to support linux users. Fixes #594 #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drmikecrowe Thank you for this PR.
There are a bunch of nitpicky things I want to change, and I will make the changes, I just need you to confirm that this approach does everything you need with respect to file ownership and permissions and allowing you to continue to run as root inside Geodesic.
Confirmed -- I'm using this in my build w/o an issue. I'm happy to adapt for future PR's if you'll share the nit-picky stuff :) |
@drmikecrowe @nitrocode @korenyoni @sboardwell Please try this version and verify it fixes the listed bugs to the extent you those bugs were bothering you, and report back here, even though this PR has been closed. Docker images are |
PR closed and released as v0.151.0-rc1. Please try it out and report back here. |
Release candidate v0.152.0-rc1 published, includes this PR and updates to Alpine and Debian versions. |
@Nuru I have a MacBook now, sorry. |
Startup shows:
Additionally, added set -x
if [[ $SHLVL == 1 ]] && [[ -n $GEODESIC_HOST_UID ]] && [[ -n $GEODESIC_HOST_GID ]] \
&& [[ -n $GEODESIC_LOCALHOST ]] && df -a | grep -q " ${GEODESIC_LOCALHOST}\$"; then output:
Dockerfile: ARG VERSION=0.151.0-rc1
ARG OS=debian
ARG CLI_NAME=infrastructure
FROM cloudposse/geodesic:$VERSION-$OS
###
### NVM for Node
####################################################################
SHELL ["/bin/bash", "--login", "-i", "-c"]
ENV NVM_DIR="/usr/local/nvm"
RUN ( git clone https://github.com/nvm-sh/nvm.git "$NVM_DIR" && \
cd "$NVM_DIR" && \
git checkout `git describe --abbrev=0 --tags --match "v[0-9]*" $(git rev-list --tags --max-count=1)` )
RUN source "$NVM_DIR/nvm.sh" && nvm install 14 && npm i -g npm npm-check-updates && npm i -g yarn
####################################################################
# Geodesic banner
ENV BANNER="Pinnacle"
RUN chmod 755 /etc/profile.d/*
COPY rootfs/ /
RUN rm -rf /localhost
WORKDIR /
( |
The files under The problem you are having is likely due to you not running the new version of the wrapper script. So far I cannot find any source for the exact message
Prior to release 0.149.0 the wrapper message was simply
With 0.149.0 the message changed to
It looks to me like you are running your own customized version of the older wrapper. Please save a copy of your custom wrapper, update your wrapper with |
what && why
prompt.sh
and Prompt Hooks Not Being Found #766notes
This PR only partly addressed #594. Work continued in #771, after which we considered #594 closed.