Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-2465: add atmos pro stack locking #678

Merged
merged 20 commits into from
Aug 20, 2024
Merged

DEV-2465: add atmos pro stack locking #678

merged 20 commits into from
Aug 20, 2024
+1,347 −244

Conversation

mcalhoun
Copy link
Member

what

  • add the atmos pro lock and atmos pro unlock commands
  • refactor the describe affected --upload command to use a new atmos pro API client
  • add a new logger implmentation so that cli args don't have to be deeply passed down the call stack. Hopefully we can migrate to this implementation over time
  • refactor redundant git code into its own package

why

To add new functionality and to promote better code reuse

@mcalhoun mcalhoun requested review from a team as code owners August 19, 2024 00:39
@mcalhoun mcalhoun requested review from Gowiem and gberenice August 19, 2024 00:39
@mcalhoun mcalhoun added the no-release Do not create a new release (wait for additional code changes) label Aug 19, 2024
aknysh
aknysh reviewed Aug 20, 2024
View reviewed changes
internal/exec/pro.go Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Aug 20, 2024
View reviewed changes
internal/exec/pro.go Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Aug 20, 2024
View reviewed changes
internal/exec/pro.go Outdated Show resolved Hide resolved
@mcalhoun @aknysh
Update internal/exec/pro.go
1e8d123 
Co-authored-by: Andriy Knysh <[email protected]>
@mcalhoun @aknysh
Update pkg/pro/api_client.go
bccdc0e 
Co-authored-by: Andriy Knysh <[email protected]>
@mcalhoun
Copy link
Member Author

@aknysh I addressed the comments (and accepted your suggestions). Could you take another look? Thanks!

aknysh
aknysh approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcalhoun mcalhoun merged commit 41048d5 into main Aug 20, 2024
22 checks passed
@mcalhoun mcalhoun deleted the feature/DEV-2465-support-stack-locking-via-cli branch August 20, 2024 13:53
@mcalhoun mcalhoun added the minor New features that do not break anything label Aug 21, 2024
This was referenced Aug 21, 2024
Draft
Open
@github-actions GitHub Actions
Copy link

These changes were released in v1.87.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice was automatically assigned from cloudposse/contributors

Assignees

@mcalhoun mcalhoun

@aknysh aknysh

Labels
minor New features that do not break anything no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcalhoun @aknysh