Skip to content

Fix #86: allow pickling functions with unhashable closure variables #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 2 commits into from
Closed

Fix #86: allow pickling functions with unhashable closure variables #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f212a0c
Fix #86: allow pickling functions with unhashable closure variables
pitrou May 23, 2017
d1cc5cc
Merge branch 'master' of https://github.com/cloudpipe/cloudpickle int…
pitrou May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudpickle/cloudpickle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def save_function_tuple(self, func):
save(_fill_function) # skeleton function updater
write(pickle.MARK) # beginning of tuple that _fill_function expects

self._save_subimports(code, set(f_globals.values()) | set(closure))
self._save_subimports(code, list(f_globals.values()) + list(closure))

# create a skeleton function object and memoize it
save(_make_skel_func)
Expand Down
5 changes: 4 additions & 1 deletion tests/cloudpickle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,10 @@ def test_nested_lambdas(self):
reason="subprocess has a bug in 3.4.0 to 3.4.2")
def test_locally_defined_function_and_class(self):
LOCAL_CONSTANT = 42
LOCAL_LIST = [] # unhashable closure variable

def some_function(x, y):
return (x + y) / LOCAL_CONSTANT
return (x + y) / LOCAL_CONSTANT + len(LOCAL_LIST)

# pickle the function definition
self.assertEqual(pickle_depickle(some_function)(41, 1), 1)
Expand Down Expand Up @@ -390,8 +391,10 @@ def test_submodule_closure(self):
# Same as test_submodule except the package is not a global
def scope():
import xml.etree.ElementTree
l = [] # unhashable closure variable
def example():
x = xml.etree.ElementTree.Comment # potential AttributeError
return len(l)
return example
example = scope()

Expand Down