feat(greenhousectl): localenv OIDC setup with admin and remote clusters #931
Conversation
There was a problem hiding this comment.
Thanks for this work!
It makes sense to onboard the remote Cluster via OIDC.
I cannot review the code changes in depth as I do not follow into the depths of unmarshalling kindConfigs to alter configuration in code.
Generally I would like to have as little rocket science as possible, but I trust your judgement on this :)
| // executePostSetup - executes post setup actions on the cluster as defined in the configuration file | ||
| // piped shell commands are converted to ShellPipe type | ||
| // NOTE: output redirects to file are not supported | ||
| func (c *Cluster) executePostSetup() error { |
There was a problem hiding this comment.
Do we have documentation on this feature?
And on all other config possibilities of Cluster (and other resources) within the localenv?
There was a problem hiding this comment.
hmmm, no but I didn't think people would need to extend this, as this is baked in the dev.config.yaml
In order to reduce complexity for Plugin Developers the Kind configuration for host path mounts are auto-generated on the fly... But with OIDC configuration also needing some host path mounts, we need to inject the plugin host path into the OIDC kind But we can also make it simple by having the plugin developers pass their own kind configuration file to the dev cli. |
Description
With the upcoming OIDC cluster connectivity feature, localenv will setup OIDC connectivity with admin and remote clusters as default setup.
Clusters can be onboarded via kubeconfig secret or via oidc secret
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist