feat(concurrentConcatAll): Add custom operator for managing multiple concurrent inner subscriptions but maintaining the output order #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concurrent inner subscriptions but maintaining the output order
zakhenry
commented
Aug 12, 2019
| @@ -7,3 +7,5 @@ export * from './lib/observable-worker.decorator'; | |||
| export * from './lib/run-worker'; | |||
| export * from './lib/from-worker'; | |||
| export * from './lib/from-worker-pool'; | |||
| // @todo move down to a 'observable-worker/helper' sub module to ensure it is not always bundled | |||
| export * from './lib/concurrent-concat-all'; | |||
There was a problem hiding this comment.
This needs to happen before merging
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
===========================================
- Coverage 100% 29.29% -70.71%
===========================================
Files 5 6 +1
Lines 73 99 +26
Branches 13 18 +5
===========================================
- Hits 73 29 -44
- Misses 0 70 +70
Continue to review full report at Codecov.
|
|
Looks like the internals of RxJS has moved with v7, and there is now a common merge operator that will make it easier to implement in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22