fix(NRC): find all node IPs for NAT exclusion #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in commit 9fd46cc when I was pulling out the krnode struct I made a mistake in the `syncNodeIPSets()` function and didn't grab the IPs of all nodes, instead I only grabbed the IP of the current node multiple times. This caused other nodes (besides the current one) to get removed from the `kube-router-node-ips` ipset which ensures that we don't NAT traffic from pods to nodes (daemons and HostNetwork'd items). This should fix that problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zerkms @mrueg @twz123 @rbrtbnfgl
Back in commit 9fd46cc when I was pulling out the krnode struct I made a mistake in the
syncNodeIPSets()function and didn't grab the IPs of all nodes, instead I only grabbed the IP of the current node multiple times.This caused other nodes (besides the current one) to get removed from the
kube-router-node-ipsipset which ensures that we don't NAT traffic from pods to nodes (daemons and HostNetwork'd items).This should fix that problem.
Fixes #1778