Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify run_dft_opt function to return hessian and frequencies #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leticia-maria
Copy link
Collaborator

TODO:

  • Add a function that corrects imaginary (negative frequencies)
  • Add tests

@bruno-ecl As of now, I have added the functionality to the run_dft_opt function, would we rather have a separate function instead or do you think the way it is right now works?

I added to the run_dft_opt because the good practice in computational chemistry is to proceed with frequency calculations after you optimize the geometry, so I thought it would be nice to have it already embedded with geometry optimization, which does mean that I could not have it as a separate function tho. 😄

@Leticia-maria
Copy link
Collaborator Author

This PR addresses #21 and #23

@Leticia-maria
Copy link
Collaborator Author

  • As per @yiwenwang47 said, frequency calculations will be optional and requested by the user. (I will just add it into a separate function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant