Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Build devkit outside of dist folder #4398

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Build devkit outside of dist folder #4398

merged 2 commits into from
Jun 25, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 25, 2020

No description provided.

@nwmac nwmac requested a review from richard-cox June 25, 2020 10:26
@nwmac nwmac self-assigned this Jun 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #4398 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4398      +/-   ##
==========================================
- Coverage   56.53%   56.52%   -0.01%     
==========================================
  Files         886      886              
  Lines       28915    28915              
  Branches     4198     4198              
==========================================
- Hits        16347    16345       -2     
- Misses      12568    12570       +2     

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once passed gates

@richard-cox richard-cox merged commit 836c841 into master Jun 25, 2020
@richard-cox richard-cox deleted the fix-devkit-dist branch June 25, 2020 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants