App Service Edit Binding: cancel of stepper results in leaked subscription #4295
Comments
richard-cox
added a commit
that referenced
this issue
Jun 12, 2020
- fixes #4295 - code no-longer needed
nwmac
pushed a commit
that referenced
this issue
Jun 17, 2020
* Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes #4052, contrinbutes to #4079, #4051 * Fix subscription leak - fixes #4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review
nwmac
added a commit
to SUSE/stratos
that referenced
this issue
Jun 29, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes cloudfoundry#4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (cloudfoundry#4321) * Fix display of details in endpoint card in endpoint list (cloudfoundry#4319) * Clean default/blocked logic * Rename @Stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes cloudfoundry#4332 * Routes List: Filter by org breaks when user is an org auditor - fixes cloudfoundry#4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (cloudfoundry#4362) * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (cloudfoundry#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes cloudfoundry#4052, contrinbutes to cloudfoundry#4079, cloudfoundry#4051 * Fix subscription leak - fixes cloudfoundry#4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (cloudfoundry#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (cloudfoundry#4389) Co-authored-by: Neil MacDougall <[email protected]> * Build devkit outside of dist folder * Ignore example packages when there's a stratos config file * Add dist-devkit to git ignore * Changes following review * Revert change needed downstream... (only needed when suse extension is included) * Fix after merge Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]>
richard-cox
added a commit
to SUSE/stratos
that referenced
this issue
Jun 29, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes cloudfoundry#4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (cloudfoundry#4321) * Fix display of details in endpoint card in endpoint list (cloudfoundry#4319) * Clean default/blocked logic * Rename @Stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes cloudfoundry#4332 * Routes List: Filter by org breaks when user is an org auditor - fixes cloudfoundry#4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (cloudfoundry#4362) * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (cloudfoundry#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes cloudfoundry#4052, contrinbutes to cloudfoundry#4079, cloudfoundry#4051 * Fix subscription leak - fixes cloudfoundry#4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (cloudfoundry#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (cloudfoundry#4389) Co-authored-by: Neil MacDougall <[email protected]> * Build devkit outside of dist folder * Ignore example packages when there's a stratos config file * Add dist-devkit to git ignore * Changes following review * Revert change needed downstream... (only needed when suse extension is included) * Fix after merge Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]>
nwmac
added a commit
to SUSE/stratos
that referenced
this issue
Jun 29, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes cloudfoundry#4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (cloudfoundry#4321) * Fix display of details in endpoint card in endpoint list (cloudfoundry#4319) * Clean default/blocked logic * Rename @Stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes cloudfoundry#4332 * Routes List: Filter by org breaks when user is an org auditor - fixes cloudfoundry#4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (cloudfoundry#4362) * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (cloudfoundry#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes cloudfoundry#4052, contrinbutes to cloudfoundry#4079, cloudfoundry#4051 * Fix subscription leak - fixes cloudfoundry#4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (cloudfoundry#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (cloudfoundry#4389) Co-authored-by: Neil MacDougall <[email protected]> * Build devkit outside of dist folder * Add dist-devkit to git ignore * Ignore example packages when there's a stratos config file (cloudfoundry#4399) * Fix CF App Restage (cloudfoundry#4393) * Remove action entityLocation (not used) * Fix restage - fixes cloudfoundry#4392 * Remove RequestEntityLocation * Update icons (cloudfoundry#4404) * Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons * Improve theming to reduce need to override in a hacky way (cloudfoundry#4407) * Change following merge Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]>
nwmac
added a commit
to SUSE/stratos
that referenced
this issue
Jun 29, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes cloudfoundry#4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (cloudfoundry#4321) * Fix display of details in endpoint card in endpoint list (cloudfoundry#4319) * Clean default/blocked logic * Rename @Stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes cloudfoundry#4332 * Routes List: Filter by org breaks when user is an org auditor - fixes cloudfoundry#4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (cloudfoundry#4362) * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (cloudfoundry#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes cloudfoundry#4052, contrinbutes to cloudfoundry#4079, cloudfoundry#4051 * Fix subscription leak - fixes cloudfoundry#4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (cloudfoundry#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * Changes following first run of script * Changes following npm install * Update custom-src to new model - expose custom module's module's - Add routing module - Tweak stratos.config.ts log output - remove custom-src dir * update naming... custom extensions --> suse extensions * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Fixes following merge from upstream * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (cloudfoundry#4389) Co-authored-by: Neil MacDougall <[email protected]> * Build devkit outside of dist folder * Ignore example packages when there's a stratos config file * Add dist-devkit to git ignore * Changes following review * Changes following merge * Update dir names, remove examples folder * Add back in custom-src deploy content, also add product version to config * Revert change needed downstream... (only needed when suse extension is included) * Ignore example packages when there's a stratos config file (cloudfoundry#4399) * Fix CF App Restage (cloudfoundry#4393) * Remove action entityLocation (not used) * Fix restage - fixes cloudfoundry#4392 * Remove RequestEntityLocation * Fix after merge * Move new terminal & config code to plugin, fix more build files * Update icons (cloudfoundry#4404) * Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons * Improve theming to reduce need to override in a hacky way (cloudfoundry#4407) * Change following merge * Fix kube config connect after merge, also fix subtype & error on connect * Fix e2e * Remove strange merge artifacts Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]>
nwmac
added a commit
to SUSE/stratos
that referenced
this issue
Jul 9, 2020
* WIP * Add theme migration * File moves * WIP * Add theme migration * Start to make core a separate library * Tweaks * WIP * Fix package imports * Fix migration script * First pass at permission effects * Fix merge issues * First pass at reducer * Tidy up logging * Fix dark theme support * Final set of cloud-foundry code out of common * TIdy up and get themable packages working * Tidy up custom build code * Tidy ups * Set defaults when no stratos.yaml file is present * FIx migrate script for when stratos.yaml not present * Remove comments * Disable scss linter from code climate * Rejig example extensions to be a package for v4 build * Renames, todos * Minor fixes * Fix frontend unit test * Fix removed e2e target * Fix unit tests * Tweaks * Finish todos * Fix transition from space summary to app summary page - an entity service for a space with no org was cached by guid - an entity service for a space requiring org used cached version - solution is to make cache id include schema key (determines with/without org) * Add comment, tidy up rootUpdatingKey * Fix issue where gitlab summary tab threw errors in console - fixes cloudfoundry#4325 * Push combine of permission configs into checkers - overcomes some weird change of permission type * Fix issue where default add/remove setting in change role by username was incorrect - add/remove radio button default value governed by add/remove feature flags - when one is set to false the radio button should be disabled and the other selected * Fix store-test-helper * Update readme following move to Travis-ci.com * Ensure the correct key is used metacard favourite info (cloudfoundry#4321) * Fix display of details in endpoint card in endpoint list (cloudfoundry#4319) * Clean default/blocked logic * Rename @Stratos to @stratosui * FIx references in tsconfig.json * Revert change to @stratosui in code * Revert change to @stratosui in code * Fix endpoint connect * Fix unit test * Fix e2e test * Change following review #1 * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream (cloudfoundry#4199) * Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 in /src/jetstream Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.4.1...v1.4.2) Signed-off-by: dependabot-preview[bot] <[email protected]> * Update go.sum Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Fix errors in console log during setup screens * Helm: Change default image pull policy to Always * Add copy address and edit to endpoint list view * Use icon that is less confusing with refresh * Change following review #2 - Fix cf package module file name - Make CUSTOM_USER_PERMISSION_CHECKERS optional - Remove need to inject CUSTOM_USER_PERMISSION_CHECKERS in multiple cf modules * Add newline at end for codeclimate * Tidy up code and add some more comments * Fix for buildpack filename wrapping on card * Fix code climate issue * Fix compilation issues * Update endpoint-list.helpers.ts * Improve naming * Tidy up * Update .gitignore * Tidy up. Build tools in dist/tools * Change following review * Rename tools to devkit. Add schematics * More improvements and theme schematic added. * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream (cloudfoundry#4336) * Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 in /src/jetstream Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.8 to 2.3.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.8...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]> * CI bump Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]> * Remove unused import * Remove unused import * [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 (cloudfoundry#4356) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fail CI build if imagelist generation fails * Org Managers: Disable org role checkboxes in roles stepper if not admin/org manager - fixes cloudfoundry#4332 * Routes List: Filter by org breaks when user is an org auditor - fixes cloudfoundry#4343 * Rename the e2e cf helper file * Fix autoscaler tab * Changes following review * A few minor tidy-ups to help with review * Fix several space developer permission bugs (cloudfoundry#4362) * Hide deployment info card if not space developer - fixes cloudfoundry#4322 * Only space developers can create/unmap/delete routes in app routes table - fixes cloudfoundry#4324 * Only Space Developers should be able to change count, terminate or ssh to instances - fixes cloudfoundry#4330 * Permissions: Only Space Developers should be able to create/edit/delete an Autoscaler policy - fixes cloudfoundry#4323 * Users with no developer roles could click on add app button - fixes cloudfoundry#4361 * Fix tests * Fix autoscaler tab * Changes following review * Fix service stepper navigation (cloudfoundry#4366) * Fix service stepper navigation on create/edit cancel/sumbit - create service stepper from app service tab, marketplace service summary, service wall - edit service stepper from marketplace service instances, service wall instances, space service instances and app service instances lists - fixes cloudfoundry#4052, contrinbutes to cloudfoundry#4079, cloudfoundry#4051 * Fix subscription leak - fixes cloudfoundry#4295 - code no-longer needed * Force return location of service stepper, fix table edit of upsi and other improvements * Fix unit tests * Fix e2e tests * Fix e2e tests, add search to marketplace service instances table * Changes following review * Move base-entity-* to store package * Add snackbar * Remove pathget * Remove more store -> core dependencies * Move extension-types to store * Move favourite mgr and helper from core to store * Move user fav manager and helper to store package * More references * Fix logger service removal * Fix build * Address PR feedback * Fix LoggerService after code moves * Fix logger service ref * Fix build issues * Fix health check import * Move sortStringify (only used once) * NonOptionalKeys - only used once * Move KnownKeys * Move BrowserStandardEncoder * Remove last environment link * Move favourite config mapper * Remove dependency on StratosScopeStrings * Move BaseEndpointAuth * Move StratosTheme * Move ThemeService * Move types from utils.service that are only used once in store * Move PermissionValues * Move http and jetstream helpers * Move StyleService * Move MetricQueryType * Move getFullEndpointApiUrl * Move StratosStatus * Move generateStratosEntities back to core * Finish store -> core sep * Address PR feedback * Fix compilation issue * Fix merge weirdness * Merge downstream (cloudfoundry#4369) * src based changes * changes to ./build * ./docs * ./ * Changes following review * Address PR feedback * fix build * whitespace changes * Fix in core public-api after merge * Fix duplicated k8s docs * Typed access to actions and entities via catalog entity: Core Stratos Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review * Theming improvements for header * Tweaks, Migration Script Docs & Notes on others (cloudfoundry#4389) Co-authored-by: Neil MacDougall <[email protected]> * Build devkit outside of dist folder * Add dist-devkit to git ignore * Ignore example packages when there's a stratos config file (cloudfoundry#4399) * Fix CF App Restage (cloudfoundry#4393) * Remove action entityLocation (not used) * Fix restage - fixes cloudfoundry#4392 * Remove RequestEntityLocation * Update icons (cloudfoundry#4404) * Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons * Improve theming to reduce need to override in a hacky way (cloudfoundry#4407) * Reduce icon size in page sub-header (cloudfoundry#4411) * Move out remaining items in cf & autoscaler from core to own packages, improve code splitting (cloudfoundry#4412) * Move out cf themese from _all-theme & remove custom cf table sort/filter field widths * Move cf routes out of app.routing & move out cf route modules from cf package module (fixes code splitting) * Fix autoscaler e2e test * Split out CF modules and router imports into custom module * Create cf-autoscaler package & routing modules - note - CfAutoscalerModule is imported in CfAutoscalerPackageModule - note - AutoscalerModule should be brought back into CfAutoscalerModule (stepper is lazy loaded.. but content missing elsewhere) * Fix autoscaler e2e test #2 * Fix app autoscaler tab widgets, import using package name * Move CfAutoscalerModule (app AS tab) out of always loaded AS package into lazy loaded app module * Add comments, fix e2e test following app-running-instance change * Allow routes to be applied to stratos navigation root without appearing in side nav * Fix app-card-app-usage on app AS tab - only seen when policy does not contain metrics restrictions - fixes by bringing in CloudFoundrySharedModule again to CfAutoscalerModule - means an also use app-running-instances again - i've checked the chunks & sizes, they're similar as before * Move CloudFoundrySharedModule out of CloudFoundryPackageModule * Add comments * Bring back in smaller search/sort input fields in main lists * Bring back lost styling * Use smaller page header on desktop browsers (cloudfoundry#4418) * Use smaller page header on desktop browsers * Change tooltip appear time * Fix issue where theming is not applied to extensions (cloudfoundry#4420) * Allow ng build to be un from any subfolder (cloudfoundry#4422) * Fix responsiveness of app instances card (cloudfoundry#4423) * Fix script to work in Jenkins (cloudfoundry#4425) * Build: Add support for packages in orgs (cloudfoundry#4427) * Allow ng build to be un from any subfolder * Add support for packages in orgs * Fixes after merge * Fix build Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: Neil MacDougall <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Neil MacDougall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: