enhance test to expect new network traffic usage fields #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geigerj0
changed the title
|
LGTM, waiting to approve/merge until the dependent PRs get merged + bumped in diego-release. |
geigerj0
commented
Aug 10, 2023
Comment on lines
+59
to
+62
| // part of the response up to "tasks" | ||
| lrps := strings.Split(string(body), "tasks")[0] | ||
| // part of the response after "tasks" | ||
| tasks := strings.Split(string(body), "tasks")[1] |
There was a problem hiding this comment.
unrelated cleanup: fixed the tests to do checks related to lrps / tasks part of the response
geofffranks
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Expect new cache fields which has been introduced with https://github.com/cloudfoundry/executor/pull/83/files#diff-ce7c6acd1213d11c38682fac36c436010409569ee2001df1a5f78fce95c57770R10-R11.
What problem it is trying to solve?
Stakeholders can't observe the network traffic usage for a particular app.
What is the impact if the change is not made?
cf tail -c metrics <app-guid> -fwill not showrx_bytesandtx_bytes.How should this change be described in diego-release release notes?
Container network traffic is now being sent to the logging stack.
Please provide any contextual information.
Tag your pair, your PM, and/or team!
Dependencies
must be merged first: