Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable global port listening #12

Closed
wants to merge 3 commits into from
Closed

Enable global port listening #12

wants to merge 3 commits into from

Conversation

jbooherl
Copy link

Add a property that enables the ability for external VMs to write to the Otel ingress porr

@jbooherl jbooherl requested a review from a team as a code owner February 28, 2024 22:04
@acrmp
Copy link
Member

acrmp commented Mar 5, 2024

Thanks @jbooherl!

Rather than using the boolean property, what if we instead just accepted an ingress.grpc.listen_address property so that we don't have to switch in the template?

We also have some template tests. Could you add an example for this case there?
https://github.com/cloudfoundry/otel-collector-release/blob/main/spec/support/shared_examples_for_otel_collector.rb

@mkocher mkocher mentioned this pull request Mar 9, 2024
@jbooherl
Copy link
Author

Sounds good, also question.. I'm not really a rubyer, when I run bundle exec rspec I get a lot of unknown keyword: :aliases Is there an easy was to fix this so I can run these tests in the future?

@ctlong
Copy link
Member

ctlong commented Mar 11, 2024

@jbooherl it looks like @mkocher has incorporated the requested change into his PR:

In that case, I think we can close out this PR, if that's alright with you?

@jbooherl
Copy link
Author

Sounds good to me!

@jbooherl jbooherl closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants