Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When we updated the Python version that this Buildpack uses in #641, a new error came out on the CI. After some workaround, I found that there is an incompatibility between
node-gyp
andpython3.11
when you are trying to build native modules using NPM<=7
.NPM is not going to fix this behavior as seen in mmomtchev/pymport#19 (an example of a native module getting errors when using npm6 and Python 3.11) because it's an old/deprecated NPM version (associated with Node
14.x
, deprecated some time ago in #608)This is fixed using NPM
>=8
Solution
Since the test is checking the behavior of Node when installing a specific version of NPM, and taking into account that the default version of the buildpack is 18.x I changed the tests to install NPM 8 (default version of 16.x) which does not present problems with the above-mentioned node-gyp behavior and follows the test purpose.