gRPC Throughput Loadbalancer (Looking for feedback) #314
Conversation
|
Hey bradylove! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150809680 The labels on this github issue will be updated when the story is started. |
|
@jasonkeene I opted for @grpc-throughputlb so that Once I finish this load balancer I will look at updating it to the new API. That balancer interface is not yet usable but I will keep an eye on it. |
|
Another thing worth looking at is the grpc-go document on load balancing. |
|
This has been updated with a simplified load balancing strategy by removing the elasticity of connections. Now the load balancer will open a given number of connections on start and then evenly balance the load between all of those connections. |
| [submodule "src/code.cloudfoundry.org/grpc-throughputlb"] | ||
| path = src/code.cloudfoundry.org/grpc-throughputlb | ||
| url = https://github.com/cloudfoundry-incubator/grpc-throughputlb | ||
| [submodule "src/github.com/alecthomas/gometalinter"] |
There was a problem hiding this comment.
I propose leaving tooling-related concerns out of our submodules, and instead add a step to install any tools to our test script.
There was a problem hiding this comment.
That got pulled in during a conflict while rebasing. Thought it was added by loggregator. I will remove.
|
I have squashed the commits which appears to have broken the PR. I am going to reopen for final review. |
This is not yet ready to merge, some investigation/work still needs to be done on the gRPC Throughput Load Balancer
This PR updates the pool to use the new gRPC Throughput Load Balancer.
The gRPC Throughput Load Balancer will grow/shrink (shrinking not yet implemented) the number of connections to Doppler as the number of concurrent requests increase. Currently each connection to Doppler is allowed 100 concurrent RPC/Stream requests. This number will need some testing and tweaking.
//cc @apoydence @enocom @jasonkeene