Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address linting and fix unit test flakiness #605

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

aqstack
Copy link
Contributor

@aqstack aqstack commented Aug 16, 2024

Description

Address lint error and test flakiness in PollerTest by increasing polling interval to 100ms to fix failing bump-dependencies job. Increasing the interval ensures Poll() runs less frequently giving the test more time to perform the assertions before the channel is updated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@aqstack aqstack requested a review from a team as a code owner August 16, 2024 22:15
Signed-off-by: Ausaf Ahmed <[email protected]>
Co-authored-by: Ausaf Ahmed <[email protected]>
@aqstack aqstack changed the title Address linting to fix failing bump-dependencies job Address linting and fix unit test flakiness Aug 17, 2024
@ctlong ctlong merged commit 0592893 into cloudfoundry:v7.x Aug 19, 2024
4 checks passed
@ctlong ctlong deleted the v7.x branch August 19, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants