Skip to content

Conversation

@jorbaum
Copy link
Contributor

@jorbaum jorbaum commented Sep 26, 2025

Lets the tests run through on MacOS ARM by properly using Sysctl.

Credit goes to
elastic@2c63039

Lets the tests run through on MacOS ARM by properly using Sysctl.

Credit goes to
elastic@2c63039
Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorbaum - thank you for taking a stab it getting this working on macOS!

Seems like the windows build is failing - I re-ran it just in case there was a flake and still got a failure.

It would be nice to enable macos-latest in the test workflow:

@github-project-automation github-project-automation bot moved this from Pending Review | Discussion to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Sep 29, 2025
@jorbaum
Copy link
Contributor Author

jorbaum commented Sep 30, 2025

It would be nice to enable macos-latest in the test workflow:

Did so.

@jorbaum
Copy link
Contributor Author

jorbaum commented Sep 30, 2025

Regarding the failing windows build:

However, I would not see this as part of this Pull Request. Also, it is difficult to test for me as I do not have a windows development machine.

@jorbaum jorbaum requested a review from aramprice September 30, 2025 15:21
@aramprice
Copy link
Member

@jorbaum - it looks like the main branch is currently succeeding on Windows[1] so it seems like there is something in this PR which is causing the windows issue[2].

Perhaps you can use this PR (or another) to bring over the Win32 changes, and rely on the github worker tests to verify?

Thanks,

-aram

[1] https://github.com/cloudfoundry/gosigar/actions/runs/17929963955/job/50984988021
[2] It could also be the case that github workers have changed in the past five days.

rubionic added a commit to rubionic/gosigar that referenced this pull request Oct 3, 2025
This PR combines two critical fixes:

1. macOS Fix (from cloudfoundry#77):
   - Updates sigar_darwin.go to use unix.SysctlUint64() for reading sysctl values
   - Fixes checkptr violations in Go 1.22+ when accessing uint64 values

2. Windows Fix (from elastic#116):
   - Implements ProcArgs.Get() using Win32 API instead of returning ErrNotImplemented
   - Replaces WMI queries with direct ReadProcessMemory and NtQueryInformationProcess calls
   - Adds helper functions: GetUserProcessParams, ReadProcessUnicodeString, ByteSliceToStringSlice
   - Adds syscall bindings for ReadProcessMemory and GetTickCount64

Fixes rkoster/rubionic-workspace#38
@jorbaum
Copy link
Contributor Author

jorbaum commented Oct 6, 2025

@jorbaum - it looks like the main branch is currently succeeding on Windows[1] so it seems like there is something in this PR which is causing the windows issue[2].

Thx. I did not see that it worked two weeks ago. AFAICS:

I guess that this is the issue. This PR should not change any windows-related code as it only changes the darwin file.

Perhaps you can use this PR (or another) to bring over the Win32 changes, and rely on the github worker tests to verify?

Looks like @rubionic is already taking on this task. Thanks!

@aramprice As a quick fix I could change windows-latest to windows-2022? What do you think?

@aramprice
Copy link
Member

@jorbaum - I think switching to windows-2022 is ok if we're still blocked by Thursday (Foundation Infrastructure working group meeing).

I'm hoping that @rkoster / @rubionic will get the other PR fixed up in the next few days and we can keep the actions windows-latest.

...until -latest is supported again.
@jorbaum
Copy link
Contributor Author

jorbaum commented Oct 15, 2025

@jorbaum - I think switching to windows-2022 is ok if we're still blocked by Thursday (Foundation Infrastructure working group meeing).

Did so.

@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Oct 16, 2025
@beyhan beyhan merged commit d72778c into cloudfoundry:master Oct 16, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Oct 16, 2025
@beyhan
Copy link
Member

beyhan commented Oct 16, 2025

@jorbaum thank you for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants