Skip to content

Conversation

@JVecsei1
Copy link
Contributor

@JVecsei1 JVecsei1 commented Aug 10, 2023

@geofffranks
Copy link
Contributor

@JVecsei1 Would you be able to add a template test for this in spec/jobs/garden_spec.rb? You can run the tests via ./scripts/template-tests. The template tests look like they fail in ruby 3.2, but succeed in 3.1.1. You can also run run them inside the cloudfoundry/garden-runc-release CI docker image if you need an easier-to-grab ruby env.

@JVecsei1 JVecsei1 force-pushed the add-network-metrics-feature-flag branch from bc4f825 to f874df7 Compare August 24, 2023 12:43
@JVecsei1
Copy link
Contributor Author

@JVecsei1 Would you be able to add a template test for this in spec/jobs/garden_spec.rb? You can run the tests via ./scripts/template-tests. The template tests look like they fail in ruby 3.2, but succeed in 3.1.1. You can also run run them inside the cloudfoundry/garden-runc-release CI docker image if you need an easier-to-grab ruby env.

@geofffranks yes, of course. I added a template test with f874df7.

@geofffranks geofffranks merged commit d369135 into cloudfoundry:develop Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants