Executor updates garden metadata #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Kocher <[email protected]>
When apps are renamed the logging tags are updated such that the new name is reflected in the log output. This change updates the tags in garden with that updated information. A new component will be reading these updated tags from garden and updating the networking config so that the dynamic updates of security groups include the correct app name in the logs. Signed-off-by: Matthew Kocher <[email protected]> Signed-off-by: Rebecca Roberts <[email protected]>
Signed-off-by: Andrew Crump <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following information:
What is this change about?
Executor updates garden metadata so that silk can get updated metadata for logging
What problem it is trying to solve?
silk sometimes will log dynamic asg info with the wrong metadata if this isn't done.
What is the impact if the change is not made?
silk sometimes will log dynamic asg info with the wrong metadata if this isn't done.
How should this change be described in diego-release release notes?
Fixed diego to enable silk to log with correct metadata