Cancel download of dependencies on failure #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsabeti
reviewed
Aug 30, 2022
dsabeti
reviewed
Aug 30, 2022
mariash
force-pushed
the
cancel-goroutines-cacheddownloader
branch
from
1e303b7 to
88569cb
Compare
Stop leaking disk space and goroutines. When one of the dependecies faisl to be downloaded cancel the rest of them and wait for goroutines to complete.
mariash
force-pushed
the
cancel-goroutines-cacheddownloader
branch
from
88569cb to
c9ae4d6
Compare
dsabeti
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
When one of the dependencies fails to be downloaded cancel the rest of them and wait for goroutines to complete.
What problem it is trying to solve?
Stop leaking disk space and goroutines.
What is the impact if the change is not made?
On errors we leak disk space in cached downloader since we forget about the goroutine and not tracking the files they download. Canceling the download will result in error that will cause the deletion of the file in cacheddownloader.
How should this change be described in diego-release release notes?
Cancel downloads of all dependencies when downloading of one of them fails.
Please provide any contextual information.
Relevant issue: cloudfoundry/diego-release#558
Thank you!