Skip to content

Conversation

@kart2bc
Copy link
Contributor

@kart2bc kart2bc commented Jun 23, 2025

Summary

set enableDeclarativeHealthCheck always to true

Backward Compatibility

Breaking Change? Yes

@kart2bc
Copy link
Contributor Author

kart2bc commented Jun 23, 2025

~/workspace/diego-release |TNZ-44150-1 S:1U:4| 
$ ./scripts/test-in-docker.bash executor
Succeeded
Using default tag: latest
latest: Pulling from cloudfoundry/tas-runtime-mysql-8.0
Digest: sha256:9f8e955c74221f3257b3b3ccb3900ceb98d7763c6db0543471bbf966c9adc26f
Status: Image is up to date for cloudfoundry/tas-runtime-mysql-8.0:latest
docker.io/cloudfoundry/tas-runtime-mysql-8.0:latest
diego-release-mysql-docker-container
fc83c024b161dfd5dc1b6e8fc3eed438c0a125f4e8ca83929a04fb1bb1060d03
go version go1.24.4 linux/amd64
/repo/src/code.cloudfoundry.org/vendor/github.com/nats-io/nats-server/v2 /
/
/tmp/build-proxy-c4XP /
/
Don't run Bundler as root. Installing your bundle as root will break this
application for all non-root users on this machine.
Fetching gem metadata from https://rubygems.org/...........
Fetching ast 2.4.2
Fetching semi_semantic 1.2.0
Installing semi_semantic 1.2.0
Installing ast 2.4.2
Using bundler 2.4.10
Fetching diff-lcs 1.5.1
Fetching json 2.9.0
Installing diff-lcs 1.5.1
Installing json 2.9.0 with native extensions
Fetching language_server-protocol 3.17.0.3
Installing language_server-protocol 3.17.0.3
Fetching parallel 1.26.3
Installing parallel 1.26.3
Fetching racc 1.8.1
Installing racc 1.8.1 with native extensions
Fetching rainbow 3.1.1
Installing rainbow 3.1.1
Fetching regexp_parser 2.9.3
Installing regexp_parser 2.9.3
Fetching rspec-support 3.13.2
Installing rspec-support 3.13.2
Fetching ruby-progressbar 1.13.0
Installing ruby-progressbar 1.13.0
Fetching unicode-emoji 4.0.4
Installing unicode-emoji 4.0.4
Fetching bosh-template 2.4.0
Installing bosh-template 2.4.0
Fetching parser 3.3.6.0
Installing parser 3.3.6.0
Fetching rspec-core 3.13.2
Installing rspec-core 3.13.2
Fetching rspec-expectations 3.13.3
Installing rspec-expectations 3.13.3
Fetching rspec-mocks 3.13.2
Installing rspec-mocks 3.13.2
Fetching unicode-display_width 3.1.2
Installing unicode-display_width 3.1.2
Fetching rubocop-ast 1.36.2
Installing rubocop-ast 1.36.2
Fetching rspec 3.13.0
Installing rspec 3.13.0
Fetching rubocop 1.69.1
Installing rubocop 1.69.1
Bundle complete! 3 Gemfile dependencies, 22 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
..........................

Finished in 0.12593 seconds (files took 0.10806 seconds to load)
26 examples, 0 failures

Sourcing: built-binaries/proxy/run.bash
Sourcing: built-binaries/nats-server/run.bash
Setting env: DB_USER
Setting env: DB_PASSWORD
Verifying: verify_go repo/src/code.cloudfoundry.org/executor
go version go1.24.4 linux/amd64
Verifying: verify_go_version_match_bosh_release repo
Verifying: verify_gofmt repo/src/code.cloudfoundry.org/executor
Verifying: verify_govet repo/src/code.cloudfoundry.org/executor
Verifying: verify_staticcheck repo/src/code.cloudfoundry.org/executor
booting mysql.........connection established to mysql
2025/07/08 14:19:19 maxprocs: Leaving GOMAXPROCS=2: CPU quota undefined
[1751984359] Executor Suite - 11/11 specs - 7 procs ••••••••••• SUCCESS! 119.243069ms 
[1751984359] ContainerMetrics Suite - 27/27 specs - 7 procs ••••••••••••••••••••••••••• SUCCESS! 321.214927ms 
[1751984359] Depot Suite - 32/32 specs - 7 procs •••••••••••••••••••••••••••••••• SUCCESS! 478.008434ms 
[1751984359] Containerstore Suite - 254/254 specs - 7 procs •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 50.99132902s 
[1751984359] Log Streamer Suite - 60/60 specs - 7 procs •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 1.237657889s 
[1751984359] Metrics Suite - 7/7 specs - 7 procs ••••••• SUCCESS! 96.458929ms 
[1751984359] Steps Suite - 262/262 specs - 7 procs •••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 5.257006122s 
[1751984359] Transformer Suite - 63/63 specs - 7 procs ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
------------------------------
↺ [FLAKEY TEST - TOOK 2 ATTEMPTS TO PASS] [1.095 seconds]
Transformer StepsRunner MonitorAction logs logs the container lifecycle
/repo/src/code.cloudfoundry.org/executor/depot/transformer/transformer_test.go:2491
------------------------------
 SUCCESS! 1.381990599s 
[1751984359] Uploader Suite - 13/13 specs - 7 procs •••••••••
------------------------------
• [0.104 seconds]
Uploader Secure Upload when the server supports tls when the client has incorrect certs fails when ca cert is wrong
/repo/src/code.cloudfoundry.org/executor/depot/uploader/uploader_test.go:343

  Captured StdOut/StdErr Output >>
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:45860: remote error: tls: bad certificate
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:45872: remote error: tls: bad certificate
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:45884: remote error: tls: bad certificate
  << Captured StdOut/StdErr Output
------------------------------
• [0.110 seconds]
Uploader Secure Upload when the server supports tls when the client has incorrect certs fails when wrong cert/keypair is provided
/repo/src/code.cloudfoundry.org/executor/depot/uploader/uploader_test.go:330

  Captured StdOut/StdErr Output >>
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:59868: tls: failed to verify certificate: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "server-ca")
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:59872: tls: failed to verify certificate: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "server-ca")
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:59886: tls: failed to verify certificate: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "server-ca")
  << Captured StdOut/StdErr Output
------------------------------
• [0.166 seconds]
Uploader Secure Upload when the server supports tls when the client has incorrect certs fails when no certs are provided
/repo/src/code.cloudfoundry.org/executor/depot/uploader/uploader_test.go:324

  Captured StdOut/StdErr Output >>
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:48562: remote error: tls: bad certificate
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:48578: remote error: tls: bad certificate
  2025/07/08 14:21:46 http: TLS handshake error from 127.0.0.1:48590: remote error: tls: bad certificate
  << Captured StdOut/StdErr Output
------------------------------
• SUCCESS! 2.614033884s 
[1751984359] HealthState Suite - 26/26 specs - 7 procs •••••••••••••••••••••••••• SUCCESS! 221.049028ms 
[1751984359] Initializer Suite - 37/37 specs - 7 procs ••••••••••••••••••••••••••••••••••••• SUCCESS! 782.458376ms 
[1751984359] Configuration Suite - 29/29 specs - 7 procs ••••••••••••••••••••••••••••• SUCCESS! 120.446799ms 

Ginkgo ran 12 suites in 2m34.791487254s
Test Suite Passed

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Jul 8, 2025
@ameowlia ameowlia marked this pull request as ready for review July 8, 2025 17:40
@ameowlia ameowlia requested a review from a team as a code owner July 8, 2025 17:40
@ameowlia ameowlia merged commit a447769 into cloudfoundry:main Jul 8, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants