This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Bump to ginkgo/v2 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkingturtle-vmw
force-pushed
the
with-ginkgo-v2
branch
from
4848a98 to
7089450
Compare
dsabeti
reviewed
Apr 6, 2023
| It("returns an error", func() { | ||
| Eventually(session).Should(gexec.Exit(4)) | ||
| Eventually(session.Err).Should(gbytes.Say("Unable to verify CredHub server")) | ||
| Eventually(session.Err).Should(gbytes.Say("Unable to interpolate credhub references")) |
Contributor
There was a problem hiding this comment.
Leaving this as a note for posterity: it looks this test has been broken for years, but this packages is being skipped in CI 😱 . I submitted a PR to fix that: cloudfoundry/diego-release#728
dsabeti
approved these changes
Apr 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.