This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add windows2016 support using WinPTY #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requires winpty-agent.exe and winpty.dll, which can be downloaded from: https://github.com/rprichard/winpty/releases. These can either be placed in the same directory as sshd.exe or have their directory given in the environment variable WINPTY_DLL_PATH - Remove external / internal build flags, replaces with windows2012R2. GOOS=windows -tags=windows2012R2 //builds for windows2012R2 GOOS=windows //builds for windows2016 - When run on windows, the tests for the handlers package and the cmd/sshd package require WINPTY_DLL_PATH to be set or they will fail - In cmd/sshd, the ItDoesNotExposeSensitiveInformation tests are skipped, as Windows does not have fork/exec [#150808829] Signed-off-by: Mark DeLillo <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: Amin Jamali <[email protected]>
|
Hey sesmith177! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151090677 The labels on this github issue will be updated when the story is started. |
sesmith177
changed the title
Contributor
|
Thanks, @sesmith177 ! Prioritizing this and cloudfoundry/diego-release#358 for the Diego team to evaluate. Best, |
Contributor
|
@stefanschneider, thought you might be interested in this one! |
|
Wooow. This is really impressive. Looking forward to see the recorded talk at CF Summit Europe :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires winpty-agent.exe and winpty.dll, which can be downloaded
from: https://github.com/rprichard/winpty/releases. These can either be
placed in the same directory as sshd.exe or have their directory given
in the environment variable WINPTY_DLL_PATH
Remove external / internal build flags, replaces with windows2012R2.
GOOS=windows -tags=windows2012R2 //builds for windows2012R2
GOOS=windows //builds for windows2016
When run on windows, the tests for the handlers package and the cmd/sshd
package require WINPTY_DLL_PATH to be set or they will fail
In cmd/sshd, the ItDoesNotExposeSensitiveInformation tests are
skipped, as Windows does not have fork/exec
[#150808829]
Signed-off-by: Mark DeLillo [email protected]
Signed-off-by: Sunjay Bhatia [email protected]
Signed-off-by: Amin Jamali [email protected]