Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@sykesm
Copy link
Contributor

@sykesm sykesm commented Dec 2, 2015

Fixes #11.

@cfdreddbot
Copy link

Hey sykesm!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/109385910.

@emalm
Copy link
Contributor

emalm commented Dec 2, 2015

Awesome, thanks, @sykesm! Prioritizing for the Diego team to pull in.

Best,
Eric

@sykesm
Copy link
Contributor Author

sykesm commented Dec 2, 2015

@emalm I'm backfilling the test for the plugin side. I'm not familiar with the cli development process so I'll have to let someone else do it there.

Should be done as soon as I refactor a bit of the InteractiveSession tests.

@emalm
Copy link
Contributor

emalm commented Dec 2, 2015

Ok, sounds good! We probably won't get to this immediately, if you have other changes to make to it.

Man, now I'm bummed out that I hadn't realized to grab the 'emalm' GitHub handle way back when. I'm @ematpl at work and @ericmalm otherwise. :(

@sykesm
Copy link
Contributor Author

sykesm commented Dec 2, 2015

Tests added.

@ghost ghost merged commit fb7cc19 into cloudfoundry:master Dec 3, 2015
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants