Ability to set datacenter in templates (defaulting to "dc1") #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey cholick! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
1 similar comment
|
Hey cholick! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/107773216. |
|
Thanks, @cholick! Prioritizing for review by the Diego team. Best, |
|
@vito merged commit 6 hours ago? Is he taking credit for your CI bot? |
|
i am omnipresent |
|
Yep, I thought that was weird too. Inclined to believe @vito's explanation. |
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template generation assumes that the cf install's consul isn't specifying the datacenter (simply using the default of
dc1). This isn't true for our installation. This pull request allows the scripts to consume datacenter when present in the ingested cf manifest and defaults todc1when not present.