-
Notifications
You must be signed in to change notification settings - Fork 218
Allow skipping of acceptance tests by using regex #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey kei-yamazaki! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
1 similar comment
|
Hey kei-yamazaki! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/105540496. |
|
Hi, @kei-yamazaki, Thanks for the contribution! Prioritizing for the Diego team to evaluate shortly. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this an array? Only one value is ever added. Please simplify.
|
Hi @kei-yamazaki, We left a comment on the pull request. Please respond and update the PR. Thanks! Best, |
|
Hi @jfmyers9 Thanks reply. Fixed to more simply code. |
|
@kei-yamazaki FYI, after merging this PR, we discussed internally and decided that /cc @ematpl |
|
I think that's good too. |
Submodule src/garden 74829d0a2..a06abf44b: > Merge pull request #123 from cloudfoundry/g115-fix > Update go.mod dependencies Submodule src/grootfs d9704e994..64717bd75: > Update go.mod dependencies > Update go.mod dependencies > Update go.mod dependencies Submodule src/guardian 8901fb77c..26cb5966f: > Update go.mod dependencies > Merge pull request #462 from cloudfoundry/g115-revisit > Update go.mod dependencies > Fix winsize type errors > Merge pull request #461 from cloudfoundry/pin-opencontainers-runc > Merge pull request #460 from cloudfoundry/g115-fix > Update go.mod dependencies Submodule src/idmapper 27d1aaa8a..4deb42ee1: > Merge pull request #82 from cloudfoundry/g115-revisit > Merge pull request #81 from cloudfoundry/g115-fix > Update go.mod dependencies
Allow skipping of acceptance tests by using regex.
Porting from cf-release.