Skip to content

Conversation

@kei-yamazaki
Copy link
Contributor

Allow skipping of acceptance tests by using regex.
Porting from cf-release.

@cfdreddbot
Copy link

Hey kei-yamazaki!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

Hey kei-yamazaki!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/105540496.

@emalm
Copy link
Contributor

emalm commented Oct 13, 2015

Hi, @kei-yamazaki,

Thanks for the contribution! Prioritizing for the Diego team to evaluate shortly.

Best,
Eric, CF Runtime Diego PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this an array? Only one value is ever added. Please simplify.

@jfmyers9
Copy link
Contributor

Hi @kei-yamazaki,

We left a comment on the pull request. Please respond and update the PR. Thanks!

Best,

@jfmyers9 && @tedsuo, CF Diego Team

@kei-yamazaki
Copy link
Contributor Author

Hi @jfmyers9

Thanks reply. Fixed to more simply code.

@luan luan merged commit f2ab018 into cloudfoundry:develop Oct 20, 2015
luan added a commit that referenced this pull request Oct 21, 2015
@luan
Copy link
Contributor

luan commented Oct 21, 2015

@kei-yamazaki FYI, after merging this PR, we discussed internally and decided that skip_regex should actually just be the regex itself, rather than a list of things to be ORed (|). So I made 6c39c39 to implement that on top of your work.

/cc @ematpl

@kei-yamazaki
Copy link
Contributor Author

I think that's good too.
Thank you for sharing!

tas-runtime-bot added a commit that referenced this pull request Nov 7, 2024
Submodule src/garden 74829d0a2..a06abf44b:
  > Merge pull request #123 from cloudfoundry/g115-fix
  > Update go.mod dependencies
Submodule src/grootfs d9704e994..64717bd75:
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Update go.mod dependencies
Submodule src/guardian 8901fb77c..26cb5966f:
  > Update go.mod dependencies
  > Merge pull request #462 from cloudfoundry/g115-revisit
  > Update go.mod dependencies
  > Fix winsize type errors
  > Merge pull request #461 from cloudfoundry/pin-opencontainers-runc
  > Merge pull request #460 from cloudfoundry/g115-fix
  > Update go.mod dependencies
Submodule src/idmapper 27d1aaa8a..4deb42ee1:
  > Merge pull request #82 from cloudfoundry/g115-revisit
  > Merge pull request #81 from cloudfoundry/g115-fix
  > Update go.mod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants