Bump to Go MySQL Driver v1.6.0 #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In 8ba0b96 we started using a fork of the Go MySQL Driver in order to address an issue seen when rolling database nodes, more background in this story: https://www.pivotaltracker.com/story/show/147786839 - Later versions of the driver include connection liveness checking which appears to mitigate the original issue: https://github.com/go-sql-driver/mysql/blob/v1.6.0/CHANGELOG.md#version-15-2020-01-07 - The ER_CONNECTION_KILLED error is a MariaDB extension to the protocol, we were only able to reproduce the original issue on MariaDB - Later versions of MariaDB appear to contain a change for compatibility with clients that can't handle a sequence number of zero: https://jira.mariadb.org/browse/MDEV-19893
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address an issue seen when rolling database nodes, more background in
this story:
https://www.pivotaltracker.com/story/show/147786839
which appears to mitigate the original issue:
https://github.com/go-sql-driver/mysql/blob/v1.6.0/CHANGELOG.md#version-15-2020-01-07
we were only able to reproduce the original issue on MariaDB
with clients that can't handle a sequence number of zero:
https://jira.mariadb.org/browse/MDEV-19893
Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:
Please make sure to complete the following steps
developbranch.Issue Link
Thank you!