Use InstanceId field instead of source_instance tag #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates loggregator_v2 client to write an application's source instance into the new `InstanceId` field. [#138719437] Signed-off-by: Andrew Poydence <[email protected]>
|
Hey enocom! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/142187317 The labels on this github issue will be updated when the story is started. |
Contributor
Author
|
Related story here. |
Contributor
|
Thanks for the update, @enocom. We'll prioritize this on the Diego team's loggregator:v2 track. Best, |
n4wei
pushed a commit
that referenced
this pull request
Oct 9, 2019
Submodule src/github.com/onsi/ginkgo eea6ad008..d90e0dcda: > Add integration test > Fix coverage files combining > A new CLI option: -ginkgo.reportFile <file path> (#601) > v1.10.2 > speed up table entry generateIt() (#609) > Fix. Write errors to stderr instead of stdout (#610) > v1.10.1 > stack backtrace: fix skipping (#600) > v1.10.0 > stack backtrace: fix alignment and skipping > fix typo in documentation > v1.9.0 > Fixed typos in comments > gofmt code > Simplify code > Simplify concatenation, incrementation and function assignment > Avoid unnecessary conversions > JUnit: include more detailed information about panic > Option to print output into report, when tests have passed > Print help to stdout when the user asks for help Submodule src/github.com/onsi/gomega 41673fd8f..bdebf9e0e: > v1.7.0 > export format property variables (#347) > minor fix in the documentation of ExpectWithOffset (#358) > v1.6.0 > Remove duplication in XML matcher tests > Remove unnecessary conversions (#357) > Fixed import order (#353) > Added missing error handling in test (#355) > Simplify code (#356) > Simplify code (#354) > Fixed typos (#352) > Add failure message tests to BeElementOf matcher > Update go-testcov untested sections > mark all uncovered files so go-testcov ./... works > display special chars on error > Reenable gotip in travis > Add BeElementOf matcher > Fix the typo of comment (#345) > Optimize contain_element_matcher > v1.5.0 > add analogous tests to fields_test.go > added tests for error messages > remove redundant validity check > ensure error messages refer to the underlying interface, not the `reflect.Value` > Run CI on go 1.12 and not 1.9 > Turn off gotip on travis > Mark session_test.go with build tag (#324) > more matcher tests > try to appease linters > MatchKeys > Clarify message for unexpected errors > make it easy to run everythin that travis would do > remove go 1.6, 1.7, 1.8 from the build matrix, and add tip > fix lint errors and use type aliases to remove stuttering > remove duplication of code and add docs to public function > v1.4.3 > test yaml parser errors and better comment on why panics are there > add test for not matcher with errors > add test for or matcher with errors > add tests for positive failure messages of Panic > ensure file name and line numbers are correctly reported > Fail the build if gofmt detects any changes required > Make changes to satisfy gofmt > Move GO111MODULE into more suitable env key in Travis > Add coverage for BeZero and Succeed matchers (#307) > Fixed matcher for content-type (#305) > v1.4.2 > Refactor goexec build test > Updates for Go v1.11 official release > Add go.mod and go.sum files to define the gomega go module > Work around go vet issue with Go v1.11 (#300) > Better output when using with go XUnit-style tests, fixes #255 (#297) > Fix MatchJSON fail to parse json.RawMessage (#298) > Move funcs shared by MatchJSON and MatchYAML to a dedicated support file > Added first failure path matching for YAML (#279) > show threshold in failure message of BeNumericallyMatcher (#293) > v1.4.1 > Update documentation (#289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates loggregator_v2 client to write an application's source
instance into the new
InstanceIdfield.[#138719437]
Signed-off-by: Andrew Poydence [email protected]