Fix powershell error handling and exit code. #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop script execution on error and return a non-zero exit code. Previously, PowerShell happily plowed through errors with little regard for traps, try catch blocks or the non-zero exits within them. [#134462851] Signed-off-by: Charlie Vieth <[email protected]>
|
Hey charlievieth! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
1 similar comment
|
Hey charlievieth! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/135347021 The labels on this github issue will be updated when the story is started. |
|
Thanks, @charlievieth! Pulling this in for evaluation by the team. Best, |
|
@bdshroyer I see this commit has been merged into develop. Should we close this PR? |
|
@sunjayBhatia I think so, yeah. |
jvshahid
added a commit
that referenced
this pull request
Oct 11, 2017
[finishes #150560620] Submodule src/code.cloudfoundry.org/locket fdeea7ad..4c4fdcbd: > fix the test to be go1.9 friendly Submodule src/github.com/onsi/gomega 334b8f47..777f4d38: > Merge pull request #230 from jvshahid/fix-gexec-on-go1.9 > Merge pull request #225 from marten-seemann/byteslice-shortcut > v1.2.0 > add TimeoutCloser, TimeoutReader, and TimeoutWriter to gbytes > assert the buffer should be closed > add gbytes.BufferReader to allow gbytes to buffer a reader > add CONTRIBUTING.md > Merge pull request #223 from spring1843/block-ending-with-return > Merge pull request #222 from apelisse/patch-1 > Remove mailing list > Merge pull request #215 from jim-slattery-rs/xunit_assertion_failures_should_be_fatal > Merge pull request #213 from aubm/xml-attr-check-with-go-1.7 > Merge pull request #212 from aubm/fix-xml-charset > Merge pull request #209 from aubm/adds-support-for-match-xml > Merge pull request #207 from madamkiwi/json_formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop script execution on error and return a non-zero exit code. Previously,
PowerShell happily plowed through errors with little regard for traps,
try catch blocks or the non-zero exits within them.
[#134462851]
Signed-off-by: Charlie Vieth [email protected]