Added a variable to disable failfast #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey axelaris! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
1 similar comment
|
Hey axelaris! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/108859756. |
|
Thanks for the PRs, @axelaris! This PR and cloudfoundry-attic/diego-acceptance-tests#1 look good to me, so I'll prioritize them for the Diego team to evaluate. Best, |
ghost
merged commit
luan
added a commit
that referenced
this pull request
Jun 30, 2016
Submodule src/github.com/cloudfoundry/gorouter df2342d..1f4d5cc (rewind): < `Uptime` metric changed to `uptime` < Fix travis build < Fix flakey uptime monitor test < Fix race condition in test < CA cert support for UAA < Send router uptime metric after draining all connections < Add uptime metrics reporter < Read request before writing response < Fix proxy test with new package name < Remove godeps and add lib to routing-release GOPATH < Exclude port in X-CF-Forwarded-Url header < Rename ssl_skip_validation to skip_ssl_validation < Use routing-release as GOPATH for travis CI < Only log when actually pruning a route to an endpoint < Return pointer to RequestHandler < Update README < Increase timeout for gorouter startup for unit tests < Update README.md < Update readme to include for standalone gorouter < Update travis to go get dependencies < Update gorouter readme and scripts to remove Godep < Remove duplicated words. < Change TTL type int -> *int < Remove godep-env script < Add modification tag to NewEndpoint method for http routes < Change syncing logic to use a buffered channel < Add necessary debug logging to see modification tag application < Register/ Unregister using modification tags < Test if route registry applies older routes < Remove Godeps < Remove .envrc file < Fix misleading message when NATS client closing. < Fix flakiness of route fetcher test < Use ioutil.NopCloser and do not write to request object in defer < Event buffering matches TCP router buffering style < Cache events during route fetching < Upgrade routing-api < Fix round tripper to avoid closing request body during retries. < Add suite tests for new packages so that ginkgo will run them < Use nats-io/gnatsd to install test dependencies < Switch the log level from info to debug < Add comment about synchronization of Trie datastructure < Log route register and unregister at INFO < Add ToPath function to Trie < Add all fakes in dropsonde < Add metric_sender/fake < Add log_sender/fake < Update tests < Update dropsonde < Run go vet after ginkgo tests to compile dependencies < Use syslog vs. stdout for sending access logs < Fix go router start message in main_test < Improve router integration test < Increase test timeout < Add more log messages for debugging < Remove skipMeasurements option passed to ginkgo in scripts/test < Update packages route_service, route_fetcher, router and stats to comply with go-vet < Update test script to use go vet and change packages to vet compliant. < Update readme for minimumRegisterIntervalInSeconds < Update Godeps < Switch to use nats-io.nats as nats client in palce of yagnats < Improve logging < Force UAA fetch token on start up < Improve log messages < Improve logging around routing api & uaa communications < Update gorouter to emit access logs with miliseconds precision. < Add coverage for uaa fetch token caching < Make access log streaming optional < Upgrade lager to get fix for serialization before sink < Update log messages in test < Remove unnecessary log messages < Bump uaa-g-client module in Godeps < Fix usage of forcedUpdate flag in call to FetchToken < Use EscapedPath for looking up for absolute as well as relative URI < Change UAA endpoint in main_test < Upgrade uaa-go-client < Gorouter route fetcher use UAA over TLS < Make routing secret more secure SHA1->SHA256 < Suppress setting Content-Type if not in response < Fix typo < Update travis to use golang 1.5 vs. 1.4 < Add RouteServiceRecommendHttps variable < Proxy respects the recommendHttps value < Add route service recommend https property < Configure gorouter to use SubscribeToEventsWithMaxRetries < Switch from uaa-token-fetcher to uaa-go-client < Update references by interface name < Update route fetcher tests and use fakes < Add uaa-go-client and update route fetcher < Remove X-CF-FORWARDED-URL Header before -> backend < Changes logging to use cf-lager conventions < Set Content-type header to nil if none is set by backend < Wrap dropsonde InstrumentedHandler to set X-Vcap-Request-Id in gorouter < Revert last commit < THE WIPEST BRANCH < Emit metrics for count of registry messages < Fix unit tests < Bump Dropsonde < GoRouter not longer writes X-Vcap-Request-Id < Report healthy only once accepting connections < Use LoggingConfig.Syslog as component name in lager < Revert "Remove syslog configuration" < Change Ω to Expect < Add X-Forwarded-Proto header if not present < Remove syslog configuration < Fixed flaky expections in registry tests < Fix flaky expectation around router drain test. < Fix expectation on session exit for main_test of gorouter. < Remove flaky expectation about specific error type when rogouter shutdown. < Generate fake event to avoid blocking in flaky test. < Fix expectation in route_fetcher_test. < Update router drain test for drain wait < During Drain() stop responding to heartbeats < bump routing-api godep dependency < Fix test message < Updated the Unauthorized error check to be less restrictive < Update tests to look for new token message < Updated log message for fetching token < Updated README about log levels present in cf_lager framework < Add tests for directing log messages to stdout < Redirect access_logs to stdout. < Remove gosteno module completely < Changed config and proxy lib to use cf_lager < replacing gosteno with cf_lager < Merge pull request #111 from cloudfoundry/shalako-patch-1 < Validate Host header characters < git ignore .swp files < gorouter fail fast after failed contact UAA < Add test for fail fast [#109854678] < Add fast fail if unable to fetch token from UAA < Bump timeout on tests failing on travis < Fix data races in tests < Only include host names with valid characters in 404 error response. < Only create route fetcher if routing api is enabled < Add additional metrics to GoRouter. < Fixes #106 - Allow HTTP request target in absolute-form < Reuse secure attribute of session cookie < Bump ifrit to get fix for multiple signals handling < Revert "Test the auto delivery of go router" < Test the auto delivery of go router < Changes to use updated uaa-token-fetcher < Remove golang 1.3 from travis < Change events log to debug setting < route_service_timeout --> route_services_timeout < Fix Godeps.json < Update dropsonde to fix issue with HttpStartStop < Merge branch 'wip-drain-test-96718176' < Merge PR #104 < Add atomic counter to remove data race condition on proxy gorouter < Update routing-api module in Godeps < Update Godeps and remove all test files < Drain client connections on error. < Change logging job name to "gorouter" < Remove default ciphers from config.go < Fix godep warning (No buildable source..) < Support unencoded secrets for route services < Add support for routing_api.auth_disabled < Update README for access log format < Avoid losing precision when printing the response time < Optimize access_log_record.go < Update readme example < Fix proxy_unit_tests < Emit router metrics through dropsonde < Upgrade dropsonde to the latest version. < Do not require X-Cf-Forwarded-Url on return from route service < Improve panic error message some more < Improve panic error message < Change Cipher Suite Order < Add response_time to access log for TCP/Websocket < Remove go1.4 from the allowed failures on travis < Fix data race in test setup < Correctly send uptime stat over varz < Update readme and documentation around boshlite < Fix gorouter flaky tests < Remove unused test (and test autobump) < Update routing-api godep dependency < Fix Travis flakiness < Separate route services secrets into 2 properties < Remove query params for Register and Unregister < Fix route lookup for context path and query string < WIP 404 context path < Added unit tests for comma separated list of secrets < Change Route Service Secrets to be a list of keys < Fix test for PR 93 < Log the contents of X-Forwarded-Proto < Restore godeps when building rss CLI < Update README to indicate how to setup the GOPATH < Make sure we check for emtpy slice. < Put the header value in quotes, also, add extra headers to the test. < Fall back to current format for extra headers instead of using json. < Enable us to specify extra headers we want to log. < Run unit test in parallel < Remove IV in crypto packages < Make vcap component logging work in GoRouter < Do not send an empty subject when publishing NATs messages < Update Travis badge to show master branch. < Add codegangsta/cli to godeps. < Add RSS CLI documentation < Change route services disable error message < Return 400 when metadata header is missing < Add tests for RSS Cli < Add default key file argument < Add Cli tool to read route service signature < Include forwarded url in route services header < Add tests for forwarded url validation < Add forwarded url to signature header < Refactor round tripper < Refactor RoundTripEventHandler < Refactor/rename RoundTripper to RoundTripEventHandler < Move setupBackendRequest to proxy round tripper < Optimize ServeHTTP in proxy.go < fix route service load balancing < Move route_service_config to route_service package < Return an error when crypto.Encrypt fails while building signature < Delete metadata header when routing to the backend instance < Refactor route service proxy code < Add test for ProxyRoundTripper and get rid of multiple WriteHeader calls < Do not call WriteHeader multiple times. < Remove unused struct members in proxyRoudTripper < Add logging statements around secret decryption < Pass in previous route service secret into the Proxy struct < GoRouter falls back to previous route_service_secret < Add route service previous key field for key rotation. < Unit test for ProxyRoundTripper. < Export some fields in proxy to unit testing easier. < fix route service expiry test < Remove signed header on route service failure < Add section about load balancing algorithm to README < Add flag to enable route services < Encrypt route service signature header < add aes gcm encryption package < Do not route to route service when backend is unavailable. < Add expiration logic to gorouter for route service signature < added context path in route pool set vcap session cookie path to context path < Do not delete Proxy signature header when routing to service on CF. < Change header field to X-CF-Proxy-Signature < Add debug logging around routing requests. < Add instructions to profile the go router < Update README to include Cache-Control and Expires headers. < Add direnv to the GoRouter. < preserve client request url in X-CF-Forwarded-Url header < Get rid of Omega character. < Route request to backend instance if a valid header exists. < Changed routing service encrypted header to RouteServiceSignature < Fix 404 error when routing to route service [#97578180] < Refactor main.go into more readable funcs [#97578180] < Add SSLSkipValidation configuration. < Add test for bad route service url. < Make proxy test registerHandler methods clearer. < Silence i/o timeouts from test testing timeouts. < Better test setup for route services < GoRouter proxies to a route service if set for requested instance. < When listing routes, the gorouter will also list the route service url if there is one. < Gorouter now parses and stores route service urls received from the routing api < Updated gorouter godeps < When router.register JSON fails to parse do not add route. < Remove mentions of the old nginx/lua router from the README. < Fixed the nats failure test. < Added the route service url field to the nats messages and endpoint < Cleaned up router_test and main_test < Merge remote-tracking branch 'origin/pr/88' < Run in go 1.4 on Travis with allowed failure. < Updated tests to use eventually instead of a blocking channel. < Revert "Replaced Ω with Expect" < Replaced Ω with Expect < Remove per-app metrics by updating Dropsonde < Fix bug where ssl enabled routers were not draining properly. < Correctly register and unregister routes with paths < Clean up Trie data structure. < Handle paths segment by segment < Merge remote-tracking branch 'origin/pr/82' < Update README.md < Serialize byUri from tree to map < Improve performance for paths with many segments < Revert "This is to route based on a path" < Revert "Fix up left Fit statement and a fmt println" < Disable compression when creating proxy connection < Fix up left Fit statement and a fmt println < This is to route based on a path < Remove additional time.Sleep calls from route_fetcher tests < Fix flaky gorouter tests < Adjust VCAP_ID as endpoint/sticky cookie changes < Update Godeps to include extracted token fetcher < Use newly extracted uaa-token-fetcher < Log outstanding active and idle connections when draining < Properly keep track of active/inactive connections < Fix data race < Update godeps < Router now subscribes to events from routing_api < Use routing_api.Client instead of manually crafting requests < Fetching routes on a interval and logging unauthorized errors < Add route fetcher to get routes from routing api < Grab uaa token < Update Notice < Refactor router < Load ssl certs via files instead of config strings. < Make tls ciphers configurable < Serve/terminate https traffic alongside http traffic Signed-off-by: Nima Kaviani <[email protected]>
tas-runtime-bot
added a commit
that referenced
this pull request
Oct 23, 2024
Submodule src/code.cloudfoundry.org/bbs e04c7c1..8a3588f: > ignore false positive on G407 (#106) Submodule src/code.cloudfoundry.org/credhub-cli 43a9b718d..e8450bcc2: > Update ginkgo and build flags Submodule src/code.cloudfoundry.org/route-emitter dc53cac..5d27c66: > feat: implement support for per-route options Submodule src/code.cloudfoundry.org/routing-info dd78756e4..3c5462d4a: > feat: implement support for per-route options Submodule src/garden 991b03c78..a21e43a17: > Update go.mod dependencies Submodule src/grootfs b3273a1d1..06954f09c: > Update go.mod dependencies Submodule src/idmapper 638ac24af..f7c358bd5: > Update go.mod dependencies
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 19, 2025
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
-failFastbehaviour for ginkgo is annoying when you want to check each other test when a single one is failing.I hope you will love this patch.
Appropriate patch for https://github.com/cloudfoundry-incubator/diego-acceptance-tests will be referred.