Cnb specs update #1008
Merged
Cnb specs update #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofffranks
approved these changes
Apr 28, 2025
plamen-bardarov
pushed a commit
to plamen-bardarov/diego-release
that referenced
this pull request
May 22, 2025
plamen-bardarov
pushed a commit
to plamen-bardarov/diego-release
that referenced
this pull request
May 22, 2025
Revert "Fix volume_mounted_files path" This reverts commit eb60021. Revert "Revert bbs submodule." This reverts commit 2865c3e. Revert "Changes according Updates cloudfoundry#1008" This reverts commit e5edeee. Revert "Refactoring." This reverts commit 9fda84c. Revert "Adding of BDD tests for setup_service_binding_root.erb." This reverts commit 5b5ed85. Revert "Remove debug." This reverts commit 579d2d0. Revert "Remove shebang for a bash." This reverts commit 6dc3da9. Revert "Adding of logging for max containers. Debug." This reverts commit a700629. Revert "Add service_binding_root to spec." This reverts commit e91be8b. Revert "Testing of rep service_binding_root" This reverts commit daee871. Revert "Add service_binding_root tmpfs." This reverts commit b3d1ad4. Revert "Restore bbs packaging" This reverts commit ffabace. Revert "Revise the service_binding_root strategy." This reverts commit 848a801. Revert "Create service binding root as tmpfs poll" This reverts commit 6dea50d. Revert "Replace bbs with the PoC version" This reverts commit 2e9a2ea.
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 19, 2025
…oundry#100) * Extend models and proto-buffers definitions for SERVICE_BINDING_ROOT. * Add some PoC code within desired_lrp_db.go * Add go.mod and go.sum for testing purpose. * Add some PoC code within desired_lrp_db.go fix. * Add some PoC code within desired_lrp_db.go debug. * Implementing service binding root size validator * Extend test scenario. * Rename filesVariables to fileBasedServiceBinding and regenerating of proto buffers. * Rename fileBasedServiceBinding to serviceBindingFiles. * Adding of BDD tests for serviceBindingFiles. * Remove go.mod and go.sum Remove scripts/generate_go_protos.sh. Restore models.go and remove PoC request. * Unify protobuf defintion for Files in desired_lrp.proto * Addressing all linter issues. * Changes according Updates cloudfoundry#1008 * Re-generating of desired_lrp.pb.go after conflicts. * Changes according to code review.
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 25, 2025
…dfoundry#56) * Adding of fake path to ServiceBindigRoot for test purpose Adding go.mod and go.sum for testing purpose. Adding of FilesVariables to executor.RunInfo Add go.mod and go.sum for testing purpose. Remove fixme. Rename filesVariables to fileBasedServiceBinding. Rename fileBasedServiceBinding to serviceBindingFiles. Remove go.mod and go.sum * Extend conversion helpers test. * Changes according Updates cloudfoundry#1008 * Extending rep to handle VolumeMountedFiles. * Changes according to code review.
kart2bc
pushed a commit
to kart2bc/diego-release
that referenced
this pull request
Aug 25, 2025
…dfoundry#100) * Adding of ServiceBindingRoot to executor config. * Implement binding root for ServiceBindigRoot * Implement the creation of service binding config files. * Add go.mod and go.sum for testing purpose. * Extend the creation of service binding config files. * Implement container sercice binding root cleanup. * Implementing BDD tests. * Rename filesVariables to fileBasedServiceBinding. * Rename fileBasedServiceBinding to serviceBindingFiles. * Remove go.mod and go.sum Remove ioutil.ReadFile in favor of os.ReadFile. Remove MkdirAll in favor of Mkdir. * Changes according Updates cloudfoundry#1008 * Change Mkdir to MkdirAll. Fixes around those changes. Refactoring of tests. * Changes according to code review. * Apply review feedback * Apply review feedback --------- Co-authored-by: i044263 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backward Compatibility
Breaking Change? No