Skip to content

Change the ReconfigurableSink to be an interface #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Change the ReconfigurableSink to be an interface #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
330efa6
Change the Reconfigurablesink to be an interface
MarcPaquette Oct 21, 2024
a83d9c1
Remove GetMinLevel() requirement from interface as it's not used
MarcPaquette Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cf_debug_server_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ func TestCfDebugServer(t *testing.T) {
var _ = SynchronizedBeforeSuite(func() []byte {
return nil
}, func(encodedBuiltArtifacts []byte) {
address = fmt.Sprintf("127.0.0.1:%d", 10000+GinkgoParallelNode())
address = fmt.Sprintf("127.0.0.1:%d", 10000+GinkgoParallelProcess())
})
10 changes: 7 additions & 3 deletions server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ type DebugServerConfig struct {
DebugAddress string `json:"debug_address"`
}

type ReconfigurableSinkInterface interface {
SetMinLevel(level lager.LogLevel)
}

func AddFlags(flags *flag.FlagSet) {
flags.String(
DebugFlag,
Expand All @@ -38,11 +42,11 @@ func DebugAddress(flags *flag.FlagSet) string {
return dbgFlag.Value.String()
}

func Runner(address string, sink *lager.ReconfigurableSink) ifrit.Runner {
func Runner(address string, sink ReconfigurableSinkInterface) ifrit.Runner {
return http_server.New(address, Handler(sink))
}

func Run(address string, sink *lager.ReconfigurableSink) (ifrit.Process, error) {
func Run(address string, sink ReconfigurableSinkInterface) (ifrit.Process, error) {
p := ifrit.Invoke(Runner(address, sink))
select {
case <-p.Ready():
Expand All @@ -52,7 +56,7 @@ func Run(address string, sink *lager.ReconfigurableSink) (ifrit.Process, error)
return p, nil
}

func Handler(sink *lager.ReconfigurableSink) http.Handler {
func Handler(sink ReconfigurableSinkInterface) http.Handler {
mux := http.NewServeMux()
mux.Handle("/debug/pprof/", http.HandlerFunc(pprof.Index))
mux.Handle("/debug/pprof/trace", http.HandlerFunc(pprof.Trace))
Expand Down