chore: Update README and test scripts #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No longer need to use `go get` to get cf-smoke-tests, as Golang has moved toward modules instead. Should use `git` to get the repo instead. - The recommended windows stack should be `windows` rather than `windows2012R2`, which I think might be deprecated (?). `windows` is the default for the `smoke_tests_windows` job in `cf-smoke-tests-release`. - Fix up some wrapping. - Other general updates for clarity.
- Don't print out commands run, as it adds unnecessary output. We already have error checking in the script. - No need to check for $GOPATH presence anymore. - Remove `CF_DIAL_TIMEOUT` export, as it was added 6 years ago and is probably outdated. I checked CATs and it's not used there anymore, which was the original impetus for adding it here. - Ensure that `ginkgo run` is executed in the right directory, removing the need to run `./bin/test` from the repo root.
This export was added ~6 years ago because it solved some issues in CATs, but it's no longer used in CATs. Besides, this script is used directly by the `smoke_test_windows` job in `cf-smoke-tests-release`, which allows for this env var to be set to a BOSH property. We shouldn't override that property here.
|
Pls ignore the CodeQL workflow for now. See #147 for more info. |
davewalter
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Updates README with latest information and refactors test scripts slightly.
Please provide contextual information.
None
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None