Fix enabling of public visibility for a single plan #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nictas! The commit authors and yourself have already signed the CLA. |
nictas
force-pushed
the
enable-service-access
branch
from
5144be6 to
4ed3f21
Compare
|
@twoseat I've only tested this via unit tests, so far. Will it be a problem for you to test it manually on your side? |
|
Almost certainly I'll create an integration test for it, so not a problem. |
|
Thanks! The unit test I've written is a bit clumsy, but I tried to follow the pattern in the test class as much as possible. It would've required significant refactoring to make the test cleaner and still keep it consistent with the rest of the tests in that class. |
nictas
force-pushed
the
enable-service-access
branch
from
4ed3f21 to
e5ec30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #913.