Skip to content

Conversation

vlast3k
Copy link
Contributor

@vlast3k vlast3k commented Sep 15, 2023

Thank you for submitting a pull request to the bbs repository!

We appreciate the contribution. To help us understand the context for your pull request, please fill out this template to the best of your ability.

Please make sure to complete all of the following steps

  1. Check the Contributing document on how to sign the CLA and run tests.
  2. Submit your PR to this repo.
  3. Submit an accompanying PR Review Request referencing this PR so the Diego Team knows to review your pull request.

Please provide the following information:

What is this change about?

Please describe.

What problem it is trying to solve?

Please describe.

What is the impact if the change is not made?

Please describe.

How should this change be described in diego-release release notes?

Something brief that conveys the change. See previous release notes for examples.

Please provide any contextual information.

Include any links to other PRs, stories, slack discussions, etc.

Tag your pair, your PM, and/or team!

It's helpful to tag someone on your team or your team alias in case we need to follow up later.

Thank you!

Copy link
Member

@mariash mariash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the issue

cloudfoundry/diego-release#820 (comment)

@vlast3k vlast3k marked this pull request as ready for review September 19, 2023 12:41
@vlast3k vlast3k requested a review from a team as a code owner September 19, 2023 12:41
@vlast3k
Copy link
Contributor Author

vlast3k commented Sep 19, 2023

@mariash , i've changed the method, to just send an event, w/o removing the LRP. Indeed i did not recognize that in the other case the Actual LRP is not directly removed.
I also added one additional unit test to validate it

@vlast3k vlast3k requested a review from mariash September 27, 2023 20:04
@mariash mariash merged commit 9c7c357 into cloudfoundry:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants