-
Notifications
You must be signed in to change notification settings - Fork 47
Add check definition interval ms to lrp 185036553 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrussett
merged 2 commits into
main
from
add-check-definition-interval-ms-to-lrp-185036553
May 15, 2023
Merged
Add check definition interval ms to lrp 185036553 #68
jrussett
merged 2 commits into
main
from
add-check-definition-interval-ms-to-lrp-185036553
May 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the interval for the health checks to be defined and configured in the check definiton of the LRP. Previously, this value was always filled in with a default when the health checks were created, now the checks can define their own interval that can be used when actually creating the checks (in the executor). Checks are now of the form: ```diff "check_definition": { "checks": [ { "http_check": { "port": 8080, "path": "/health", - "request_timeout_ms": 10000 + "request_timeout_ms": 10000, + "interval_ms": 123 }, } ], "readiness_checks": [ { "tcp_check": { "port": 8080, - "connect_timeout_ms": 10000 + "connect_timeout_ms": 10000, + "interval_ms": 123 }, } ], "log_source": "" }, ``` Check json example adapted from our design document (Publicly Accessible): https://docs.google.com/document/d/1AS8GzKg3pdAv56nySQTgF4NaqqzrBwmztkL2_8ahKa4/edit?usp=sharing Signed-off-by: Marc Paquette <[email protected]> [#185036553](https://www.pivotaltracker.com/story/show/185036553) Signed-off-by: Josh Russett <[email protected]> Signed-off-by: Marc Paquette <[email protected]>
We don't need to touch the actual_lrp at all for the interval_ms changes. This file got updated when we were generating new protobuf stuff for the changes to the desired_lrp. This will eventually get updated by the dynamic tracing PRs, so we aren't missing anything. [#185036553](https://www.pivotaltracker.com/story/show/185036553)
mariash
pushed a commit
that referenced
this pull request
May 23, 2023
* Add interval_ms param for health check definitions This change allows the interval for the health checks to be defined and configured in the check definiton of the LRP. Previously, this value was always filled in with a default when the health checks were created, now the checks can define their own interval that can be used when actually creating the checks (in the executor). Checks are now of the form: ```diff "check_definition": { "checks": [ { "http_check": { "port": 8080, "path": "/health", - "request_timeout_ms": 10000 + "request_timeout_ms": 10000, + "interval_ms": 123 }, } ], "readiness_checks": [ { "tcp_check": { "port": 8080, - "connect_timeout_ms": 10000 + "connect_timeout_ms": 10000, + "interval_ms": 123 }, } ], "log_source": "" }, ``` Check json example adapted from our design document (Publicly Accessible): https://docs.google.com/document/d/1AS8GzKg3pdAv56nySQTgF4NaqqzrBwmztkL2_8ahKa4/edit?usp=sharing Signed-off-by: Marc Paquette <[email protected]> [#185036553](https://www.pivotaltracker.com/story/show/185036553) Signed-off-by: Josh Russett <[email protected]> Signed-off-by: Marc Paquette <[email protected]> * Do not modify actual_lrp We don't need to touch the actual_lrp at all for the interval_ms changes. This file got updated when we were generating new protobuf stuff for the changes to the desired_lrp. This will eventually get updated by the dynamic tracing PRs, so we aren't missing anything. [#185036553](https://www.pivotaltracker.com/story/show/185036553) --------- Signed-off-by: Josh Russett <[email protected]> Signed-off-by: Marc Paquette <[email protected]>
MarcPaquette
pushed a commit
to MarcPaquette/community
that referenced
this pull request
May 25, 2023
…prover Diego Approver cloudfoundry/bbs#64 cloudfoundry/bbs#68 cloudfoundry/diego-dockerfiles@3aa03b8 cloudfoundry/diego-dockerfiles@77dccfa cloudfoundry/diego-dockerfiles@c69911c cloudfoundry/diego-dockerfiles@df0aed2 cloudfoundry/diego-release@05dcaba cloudfoundry/diego-release@390d5d7 cloudfoundry/diego-release@4d5e6a1 cloudfoundry/diego-release@5158007 cloudfoundry/diego-release#740 cloudfoundry/docs-cloudfoundry-concepts#181 cloudfoundry/dontpanic#39 cloudfoundry/executor#76 cloudfoundry/executor#80 cloudfoundry/grace#3 cloudfoundry/healthchecker-release#2 cloudfoundry/wg-app-platform-runtime-ci@03fa33d cloudfoundry/wg-app-platform-runtime-ci@3affeda PR Reviews: cloudfoundry/buildpackapplifecycle#55 cloudfoundry/cacheddownloader#18 cloudfoundry/diego-release#689 cloudfoundry/diego-release#690 cloudfoundry/diego-release#704 cloudfoundry/diego-release#728
ameowlia
pushed a commit
to cloudfoundry/community
that referenced
this pull request
May 30, 2023
…prover Diego Approver cloudfoundry/bbs#64 cloudfoundry/bbs#68 cloudfoundry/diego-dockerfiles@3aa03b8 cloudfoundry/diego-dockerfiles@77dccfa cloudfoundry/diego-dockerfiles@c69911c cloudfoundry/diego-dockerfiles@df0aed2 cloudfoundry/diego-release@05dcaba cloudfoundry/diego-release@390d5d7 cloudfoundry/diego-release@4d5e6a1 cloudfoundry/diego-release@5158007 cloudfoundry/diego-release#740 cloudfoundry/docs-cloudfoundry-concepts#181 cloudfoundry/dontpanic#39 cloudfoundry/executor#76 cloudfoundry/executor#80 cloudfoundry/grace#3 cloudfoundry/healthchecker-release#2 cloudfoundry/wg-app-platform-runtime-ci@03fa33d cloudfoundry/wg-app-platform-runtime-ci@3affeda PR Reviews: cloudfoundry/buildpackapplifecycle#55 cloudfoundry/cacheddownloader#18 cloudfoundry/diego-release#689 cloudfoundry/diego-release#690 cloudfoundry/diego-release#704 cloudfoundry/diego-release#728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Add interval_ms param for health check definitions
This change allows the interval for the health checks to be defined and
configured in the check definition of the LRP. Previously, this value was
always filled in with a default when the health checks were created, now
the checks can define their own interval that can be used when actually
creating the checks (in the executor).
Checks are now of the form:
Please provide any contextual information.
Associated executor PR: cloudfoundry/executor#80
Check json example adapted from our design document (Publicly Accessible):
https://docs.google.com/document/d/1AS8GzKg3pdAv56nySQTgF4NaqqzrBwmztkL2_8ahKa4/edit?usp=sharing
#185036553
Tag your pair, your PM, and/or team!
@MarcPaquette