This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Make consulTTL value configurable #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark DeLillo <[email protected]>
|
Hey mdelillo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/131553215 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
delivered
in progress
accepted
and removed
unscheduled
delivered
in progress
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with all the diego components behaving this way, the consul in PCF Dev gets overloaded and goes unresponsive.
PCF Dev needs this value to be increased/configurable.
This became necessary when these services switch from using
dns_health_checkto the TTL method. When thedns_health_checkdoes not succeed within the TTL, consul will still respond to DNS queries for that service. Using the new TTL method, consul will unregister the service from it's DNS registry if it fails to update it's healthcheck status within the TTL.Signed-off-by: Anthony Emengo [email protected]
Signed-off-by: Mark DeLillo [email protected]