This repository has been archived by the owner on Jul 3, 2021. It is now read-only.
Add kubelet-pre-stop-password to cfcr.yml #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PKS users, Alana or Cody, want to assign labels or taint to nodes. And those labels and taints are expected to be persistent regardless of PKS upgrade, bosh recreate VM or other incidents - unless the operator removed it intentionally.
How can this PR be verified?
https://pks.ci.cf-app.com/teams/dev/pipelines/pks-api-persist_node_taint_label
Is there any change in kubo-release?
yes
https://github.com/pivotal-cf/pks-kubernetes-release/pull/66
Is there any change in kubo-ci?
no
Does this affect upgrade, or is there any migration required?
no migration
Which issue(s) this PR fixes:
https://docs.google.com/document/d/1mbhPLfMw0sbMcNScQm5aeJhQTwZf76V0pZQkpMbXmy8/edit?ts=5eb51956&pli=1#
https://www.pivotaltracker.com/story/show/172862983