Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix including all package bin directories #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix including all package bin directories #49

wants to merge 1 commit into from

Conversation

sharms
Copy link

@sharms sharms commented Jun 3, 2016

  • Including all bin directories under /packages can result in deployment errors depending on which combination of jobs is deployed. For example, Concourse can use busybox which may bring in a new core utility which does not behave as expected, resulting in a failed deployment
  • This change scopes the PATH includes to only use /var/vcap/packages/admin_ui bin directories

@sharms
Fix including all package bin directories- Including all bin director…
a4c88ea 
…ies under /packages can result in deployment errors depending on which combination of jobs is deployed. For example, Concourse can use busybox which may bring in a new core utility which does not behave as expected, resulting in a failed deployment

- This change scopes the PATH includes to only use /var/vcap/packages/admin_ui bin directories
@sharms
Copy link
Author

sharms commented Sep 8, 2016

This package has no dependencies in /var/vcap/packages outside of itself, can we get this merged?

@sharms
Copy link
Author

sharms commented Dec 2, 2016

Reminder that this is still an outstanding bug and this is a complete fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sharms