-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: work with Cloudflare WARP #963
Conversation
🦋 Changeset detectedLatest commit: ad1ce22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dec078f
to
0d810e9
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2307096669/npm-package-wrangler-963 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/963/npm-package-wrangler-963 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2307096669/npm-package-wrangler-963 dev path/to/script.js |
Huh, I'm actually able to reproduce the test failures locally. Investigating. |
Using wrangler with Cloudflare WARP (https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/warp/) requires using the Cloudflare certificate. This patch simply uses the certificate as NODE_EXTRA_CA_CERTS when we start wrangler. Test plan: - Turn on Cloudflare WARP/ Gateway with WARP - `wrangler dev` - Turn on Cloudflare WARP/ Gateway with DoH - `wrangler dev` - Turn off Cloudflare WARP - `wrangler dev` Fixes #953, #850
0d810e9
to
ad1ce22
Compare
Alright, I figured it out. You need to extend |
// use cloudflare WARP, but let's wait till the situation actually | ||
// arises before we do anything about it | ||
} else { | ||
pathToCACerts = join(__dirname, "../Cloudflare_CA.pem"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luckily you can get away with using __dirname
here because we are not bundling this file with esbuild 😺
Using wrangler with Cloudflare WARP (https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/warp/) requires using the Cloudflare certificate. This patch simply uses the certificate as NODE_EXTRA_CA_CERTS when we start wrangler.
Test plan:
wrangler dev
wrangler dev
wrangler dev
Fixes #953, #850