Suppress beta warning when operating in Pages' CI environment #934
Conversation
GregBrimble
added
pages
GregBrimble
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: 2fd2577 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2293683753/npm-package-wrangler-934You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/934/npm-package-wrangler-934Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2293683753/npm-package-wrangler-934 dev path/to/script.js |
| logger.log(pagesBetaWarning); | ||
| if (!isInPagesCI) { | ||
| // Beta message for `wrangler pages <commands>` usage | ||
| logger.log(pagesBetaWarning); |
There was a problem hiding this comment.
is this the only one to silence? I see 11 instances in the codebase, but just confirming they they won't be hit in CI.
There was a problem hiding this comment.
Yes, this is the only command that we run in CI. I figure if users are running other commands themselves in CI, we still want to warn them.
We've had a couple of people flagging this as weird to show up in our official prod build image logs. This PR suppresses those warnings for the
wrangler build functionscommand that we run to generate their Functions Worker.Fixes #855