feat: offer to create a git repo when calling wrangler init
#922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker projects created by `wrangler init` should also be managed by source control (popularly, git). This patch adds a choice in `wrangler init` to make the created project into a git repository. Additionally, this fixes a bug in our tests where mocked `confirm()` and `prompt()` calls were leaking between tests. Closes #847
🦋 Changeset detectedLatest commit: 2802fcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2289064155/npm-package-wrangler-922You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/922/npm-package-wrangler-922Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2289064155/npm-package-wrangler-922 dev path/to/script.js |
|
I'm going to land this so I can do a release and test it out, but feel free to leave comments and I'll def work on them. |
Merged
|
yup, it had bugs lol #924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker projects created by
wrangler initshould also be managed by source control (popularly, git). This patch adds a choice inwrangler initto make the created project into a git repository.Additionally, this fixes a bug in our tests where mocked
confirm()andprompt()calls were leaking between tests.Closes #847