Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bold font from additional lines of warnings and errors #893

Merged
merged 2 commits into from
May 4, 2022

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented May 4, 2022

Previously, when a warning or error was logged, the entire message
was formatted in bold font. This change makes only the first line of
the message bold, and the rest is formatted with a normal font.

Before

Screenshot 2022-05-04 at 14 50 08

After

Screenshot 2022-05-04 at 14 49 04

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

🦋 Changeset detected

Latest commit: 3011481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2271399965/npm-package-wrangler-893

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/893/npm-package-wrangler-893

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2271399965/npm-package-wrangler-893 dev path/to/script.js

@petebacondarwin
Copy link
Contributor Author

Urgh the unit tests fail because the CI has a narrower screen than the one I am using...

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg YES!! insta stamp, while you figure out tests. While you're at it, how about also marking the title of deprecated() messages as chalk.bold()?

Previously, when a warning or error was logged, the entire message
was formatted in bold font. This change makes only the first line of
the message bold, and the rest is formatted with a normal font.
Note that we do not use Chalk here because that will change the inline
snapshots in the CI.
@petebacondarwin petebacondarwin merged commit 5bf17ca into cloudflare:main May 4, 2022
@petebacondarwin petebacondarwin deleted the log-formatting branch May 4, 2022 18:44
@github-actions github-actions bot mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants