Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leading slashes to Pages manifest #892

Merged
merged 1 commit into from
May 4, 2022

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented May 4, 2022

This adds the leading slash to a Pages deployment manifest that the API expects, and also fixes manifest generation on Windows: classic backslash vs. forwardslash problems.

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

🦋 Changeset detected

Latest commit: 2d34fcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2270009624/npm-package-wrangler-892

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/892/npm-package-wrangler-892

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2270009624/npm-package-wrangler-892 dev path/to/script.js

@petebacondarwin petebacondarwin marked this pull request as draft May 4, 2022 12:59
@GregBrimble GregBrimble force-pushed the add-leading-slashes-to-pages-manifest branch 2 times, most recently from 75fe572 to 97c040e Compare May 4, 2022 13:19
@GregBrimble GregBrimble force-pushed the add-leading-slashes-to-pages-manifest branch from 97c040e to 2d34fcb Compare May 4, 2022 13:22
@GregBrimble GregBrimble marked this pull request as ready for review May 4, 2022 13:23
@GregBrimble GregBrimble changed the title WIP: Add leading slashes to Pages manifest Add leading slashes to Pages manifest May 4, 2022
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish Windows was really POSIX compliant

@sidharthachatterjee sidharthachatterjee merged commit b08676a into main May 4, 2022
@sidharthachatterjee sidharthachatterjee deleted the add-leading-slashes-to-pages-manifest branch May 4, 2022 13:53
@github-actions github-actions bot mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants