polish: s/DEPRECATION/Deprecation #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the scary uppercase from DEPRECATION warnings. It also moves the service environment usage warning into `diagnostics` instead of logging it directly.
🦋 Changeset detectedLatest commit: 8f3851c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2268679074/npm-package-wrangler-888You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/888/npm-package-wrangler-888Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2268679074/npm-package-wrangler-888 dev path/to/script.js |
petebacondarwin
approved these changes
May 4, 2022
|
And we also have some full caps "DO NOT USE THIS" in deprecation warnings, which could be toned down too. |
|
Good point, yes. I'll send another PR asap. |
Merged
threepointone
added a commit
that referenced
this pull request
May 4, 2022
Followup to #888, this replaces some more scary capitals with a more chill word.
petebacondarwin
pushed a commit
that referenced
this pull request
May 4, 2022
Followup to #888, this replaces some more scary capitals with a more chill word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the scary uppercase from DEPRECATION warnings. It also moves the service environment usage warning into
diagnosticsinstead of logging it directly.