feat: implement service environments + durable objects #868
Conversation
🦋 Changeset detectedLatest commit: ac9eed5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2259310388/npm-package-wrangler-868You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/868/npm-package-wrangler-868Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2259310388/npm-package-wrangler-868 dev path/to/script.js |
threepointone
force-pushed
the
durable-service-envs
branch
2 times, most recently
from
d1e3f43
to
a65e778
Compare
| const foundIndex = config.migrations.findIndex( | ||
| (migration) => migration.tag === script.migration_tag | ||
| (migration) => migration.tag === scriptMigrationTag |
There was a problem hiding this comment.
I had to do this because typescript was being weird and saying script could be undefined here (but not saying so for any further occurrence of script.migration_tag 🤷♂️)
threepointone
force-pushed
the
durable-service-envs
branch
from
a65e778
to
527b067
Compare
packages/wrangler/src/publish.ts
Outdated
| } | ||
| } catch (err) { | ||
| if ( | ||
| [10090, 10092].includes((err as { code: number }).code) === false |
There was a problem hiding this comment.
i feel like this should just be ![10090, 10092].includes((err as { code: number }).code), right?
There was a problem hiding this comment.
Can we also add comments for what these error numbers mean
There was a problem hiding this comment.
heh I'd originally had it in that form, happy to revert to it. I'll add comments for the codes.
threepointone
force-pushed
the
durable-service-envs
branch
from
527b067
to
6589b09
Compare
Now that the APIs for getting migrations tags of services works as expected, this lands support for publishing durable objects to service environments, including migrations. It also removes the error we used to throw when attempting to use service envs + durable objects. Fixes #739
threepointone
force-pushed
the
durable-service-envs
branch
from
6589b09
to
ac9eed5
Compare
Now that the APIs for getting migrations tags of services works as expected, this lands support for publishing durable objects to service environments, including migrations. It also removes the error we used to throw when attempting to use service envs + durable objects.
Fixes #739