-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: site.entry-point
should not be a hard deprecation
#843
Conversation
🦋 Changeset detectedLatest commit: 7d81a81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7fa7a9a
to
79a8e2e
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2266650886/npm-package-wrangler-843 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/843/npm-package-wrangler-843 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2266650886/npm-package-wrangler-843 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good.
The example app is just copied directly from wrangler 1, right?
The messaging is a little confusing to me. The deprecation warning is that site.entry-point
is no longer used, but actually it seems like we do actually respect it? If that's the case, then maybe we should instead encourage people to move site.entry-point
to main
?
Like basically my nit is that the messaging implies we're ignoring site.entry-point
but actually...we're not. I think..? Other than that though, looks good :)
Good point about the messages, I reused what it already was. I'll rewrite it. |
tbh I did such a shoddy job with this PR, noticing that I just commented out a couple of tests I should have implemented. Working today on making this a lot better. |
7cd70da
to
398d964
Compare
Alright, let's try this again. Messaging better aligned with our other deprecations, better tests. What do you think? |
ee931ac
to
a40e9d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Approving with some minor nits that you can do if you want, and a request to create a follow-up issue for normalizing windows paths in tests
a40e9d3
to
ab11769
Compare
2ee5072
to
148d3b8
Compare
To make migration of v1 projects easier, Sites projects should still work, including the `entry-point` field (which currently errors out). This enables `site.entry-point` as a valid entry point, with a deprecation warning.
148d3b8
to
7d81a81
Compare
Thanks for the reviews and the patience peeps. Landing this now. |
To make migration of v1 projects easier, Sites projects should still work, including the
entry-point
field (which currently errors out). This enablessite.entry-point
as a valid entry point, with a deprecation warning.I also added an example repo, which is simply the output of
wrangler generate --site